Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showing correct name in table format for artifact tags list cmd #257

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Showing correct name in table format for artifact tags list cmd #257

wants to merge 8 commits into from

Conversation

Althaf66
Copy link
Collaborator

@Althaf66 Althaf66 commented Nov 14, 2024 •
edited
Loading

This fix #256
Before
Screenshot from 2024-11-15 00-34-53

After
harbor artifact tags list
Screenshot from 2024-11-15 00-54-00

@Althaf66
modified tag list cmd
6fd6835 
Signed-off-by: ALTHAF <althafasharaf02@gmail.com>
@Althaf66
modified tag list cmd
e550f9c 
Signed-off-by: ALTHAF <althafasharaf02@gmail.com>
@Althaf66
added flag for tag list cmd and modified
ef1cbae 
Signed-off-by: ALTHAF <althafasharaf02@gmail.com>
@Althaf66
added flag for tag list cmd and modified
1f82739 
Signed-off-by: ALTHAF <althafasharaf02@gmail.com>
@bupd bupd self-requested a review November 21, 2024 06:51
bupd
bupd requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

❯ ./harbor-dev artifact tags list "alpine/alpine/sha256:675c712e53bc9534c61ce7fd13e0a0cb188ba6b7626ae73a5a3da42db49a40b6"

the argument should be project/repo@digest instead of project/repo/digest.

@Standing-Man
Copy link
Contributor 

❯ ./harbor-dev artifact tags list "alpine/alpine/sha256:675c712e53bc9534c61ce7fd13e0a0cb188ba6b7626ae73a5a3da42db49a40b6"

the argument should be project/repo@digest instead of project/repo/digest.

Hi @bupd, I bet most people won’t be able to remember that random string of a digest. 😂

@Vad1mo Vad1mo added the help wanted Extra attention is needed label Dec 3, 2024
@Althaf66 Althaf66 mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bupd bupd bupd requested changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing pointer value for tag list cmd
4 participants
@Althaf66 @Standing-Man @bupd @Vad1mo