Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ping command to check Harbor connectivity #321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ravjot07
Copy link

@ravjot07 ravjot07 commented Feb 5, 2025

Description:
This PR introduces a new ping command to the Harbor CLI, allowing users to verify connectivity with the Harbor server. The command calls the existing api.Ping() function and returns a success message (Pong!) if the server is reachable.

Changes Introduced:

  • Added a new ping command in cmd/harbor/root/ping.go.
  • Registered PingCommand() in cmd/harbor/root/cmd.go.
  • Calls api.Ping() from pkg/api/ping_handler.go.

Usage Example:

harbor ping

Output (if successful):

Pong! Successfully contacted the Harbor server.

contributes towards #94 and #315

Signed-off-by: Ravjot Singh <ravu2004@gmail.com>
@Standing-Man
Copy link
Contributor

Hi @ravjot07, thank you for your contribution! The ping handler has already been implemented in PR #285. If you're still interested in this project, feel free to explore other issues to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants