-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify registry build #20622
Open
kariya-mitsuru
wants to merge
6
commits into
goharbor:main
Choose a base branch
from
kariya-mitsuru:simplify-registry-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Simplify registry build #20622
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
64956e3
Simplify registry build
kariya-mitsuru c0c2265
Revert make/photon/registry/Dockerfile.base
kariya-mitsuru 584df97
Use RUN with bind mount instead of COPY
kariya-mitsuru 28a35ba
Capitalize `FROM AS`
kariya-mitsuru 8578deb
Merge branch 'main' into simplify-registry-build
kariya-mitsuru e611f70
Merge branch 'main' into simplify-registry-build
chlins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
#!/bin/bash | ||
|
||
set +e | ||
set -e | ||
|
||
if [ -z $1 ]; then | ||
error "Please set the 'version' variable" | ||
echo "Please set the 'version' variable" | ||
exit 1 | ||
fi | ||
|
||
|
@@ -15,36 +15,24 @@ fi | |
VERSION="$1" | ||
DISTRIBUTION_SRC="$2" | ||
|
||
set -e | ||
|
||
# the temp folder to store binary file... | ||
mkdir -p binary | ||
rm -rf binary/registry || true | ||
|
||
cd `dirname $0` | ||
cur=$PWD | ||
|
||
# the temp folder to store distribution source code... | ||
TEMP=`mktemp -d ${TMPDIR-/tmp}/distribution.XXXXXX` | ||
git clone -b $VERSION $DISTRIBUTION_SRC $TEMP | ||
git clone -b $VERSION --depth 1 $DISTRIBUTION_SRC $TEMP | ||
|
||
# add patch redis | ||
cd $TEMP | ||
git apply $cur/redis.patch | ||
cd $cur | ||
git apply ~-/redis.patch | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does it support all the linux OS versions? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. |
||
cd - | ||
|
||
echo 'build the registry binary ...' | ||
cp Dockerfile.binary $TEMP | ||
docker build -f $TEMP/Dockerfile.binary -t registry-golang $TEMP | ||
|
||
echo 'copy the registry binary to local...' | ||
ID=$(docker create registry-golang) | ||
docker cp $ID:/go/src/github.com/docker/distribution/bin/registry binary/registry | ||
|
||
docker rm -f $ID | ||
docker rmi -f registry-golang | ||
docker build -f Dockerfile.binary -o binary/ $TEMP | ||
|
||
echo "Build registry binary success, then to build photon image..." | ||
cd $cur | ||
cp $TEMP/cmd/registry/config-example.yml config.yml | ||
rm -rf $TEMP |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
PREFIX
variable is not used anywhere, which leads to confusion.Therefore, I think it is better to remove it.