Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Changes for Configuring Proxy-Cache Speed Limit #20946

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

kunal-511
Copy link
Contributor

proxy-cache bandwidth limit UI change

Comprehensive Summary of your change

This pull request addresses the UI changes required for configuring the proxy-cache speed limit, as outlined in Issue #20589 The changes include the addition of a bandwidth field for setting the speed limit in both the proxy-cache creation page and the project configuration page

Issue being fixed

Fixes #20811

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.18%. Comparing base (c8c11b4) to head (b0ac4dd).
Report is 284 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20946       +/-   ##
===========================================
+ Coverage   45.36%   66.18%   +20.81%     
===========================================
  Files         244     1048      +804     
  Lines       13333   114467   +101134     
  Branches     2719     2855      +136     
===========================================
+ Hits         6049    75756    +69707     
- Misses       6983    34566    +27583     
- Partials      301     4145     +3844     
Flag Coverage Δ
unittests 66.18% <ø> (+20.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1287 files with indirect coverage changes

@stonezdj stonezdj added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Sep 20, 2024
@stonezdj
Copy link
Contributor

CI / UI_UT failed

@stonezdj stonezdj force-pushed the ui-feat-#20811 branch 2 times, most recently from 29d75fb to 4e3072b Compare September 27, 2024 03:25
kunal-511 and others added 3 commits September 27, 2024 11:25
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit ab400c9 into goharbor:main Sep 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy-cache bandwidth limit UI change
5 participants