-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Changes for Configuring Proxy-Cache Speed Limit #20946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20946 +/- ##
===========================================
+ Coverage 45.36% 66.18% +20.81%
===========================================
Files 244 1048 +804
Lines 13333 114467 +101134
Branches 2719 2855 +136
===========================================
+ Hits 6049 75756 +69707
- Misses 6983 34566 +27583
- Partials 301 4145 +3844
Flags with carried forward coverage won't be shown. Click here to find out more. |
stonezdj
added
the
release-note/enhancement
Label to mark PR to be added under release notes as enhancement
label
Sep 20, 2024
stonezdj
reviewed
Sep 23, 2024
src/portal/src/app/base/left-side-nav/projects/create-project/create-project.component.ts
Outdated
Show resolved
Hide resolved
stonezdj
approved these changes
Sep 25, 2024
stonezdj
force-pushed
the
ui-feat-#20811
branch
from
September 25, 2024 08:05
b6002e7
to
eb379a0
Compare
|
stonezdj
force-pushed
the
ui-feat-#20811
branch
2 times, most recently
from
September 27, 2024 03:25
29d75fb
to
4e3072b
Compare
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
stonezdj
force-pushed
the
ui-feat-#20811
branch
from
September 27, 2024 03:25
4e3072b
to
b0ac4dd
Compare
MinerYang
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-note/enhancement
Label to mark PR to be added under release notes as enhancement
target/2.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxy-cache bandwidth limit UI change
Comprehensive Summary of your change
This pull request addresses the UI changes required for configuring the proxy-cache speed limit, as outlined in Issue #20589 The changes include the addition of a bandwidth field for setting the speed limit in both the proxy-cache creation page and the project configuration page
Issue being fixed
Fixes #20811
Please indicate you've done the following: