fix: invalid indirect read from stack #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following verifier log is caused by uninitilized stack variable. ```log couldn't init manager xxx verifier error:load program: permission denied: 0: R1=ctx(off=0,imm=0) R10=fp0 ; struct sock *sk = (struct sock *)PT_REGS_PARM1(ctx); 0: (79) r2 = *(u64 *)(r1 +112) ; R1=ctx(off=0,imm=0) R2_w=scalar() 1: (b7) r3 = 1 ; R3_w=1 ; conn.is_destroy = 1; 2: (73) *(u8 *)(r10 -8) = r3 ; R3_w=1 R10=fp0 fp-8=1 ; conn.sock = (u64)sk; 3: (7b) *(u64 *)(r10 -16) = r2 ; R2_w=scalar() R10=fp0 fp-16_w=mmmmmmmm 4: (bf) r4 = r10 ; R4_w=fp0 R10=fp0 ; 5: (07) r4 += -64 ; R4_w=fp-64 ; bpf_perf_event_output(ctx, &connect_events, BPF_F_CURRENT_CPU, &conn, 6: (18) r2 = 0xffff8dd41e9c0000 ; R2_w=map_ptr(off=0,ks=4,vs=4,imm=0) 8: (18) r3 = 0xffffffff ; R3_w=4294967295 10: (b7) r5 = 64 ; R5_w=64 11: (85) call bpf_perf_event_output#25 invalid indirect read from stack R4 off -64+0 size 64 processed 10 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0 ``` Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
Asphaltt
force-pushed
the
fix/stack-indirect-access
branch
from
b4bf74d to
5a1549e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692
The following verifier log is caused by uninitilized stack variable.