Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the issue of missing cross-compilation environment. #709

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

cfc4n
Copy link
Member

@cfc4n cfc4n commented Dec 28, 2024

User description

Github Action release.yml run failed in Release arm64 (CROSS COMPILATION) phase

cd lib/libpcap && \
	CC=aarch64-linux-gnu-gcc AR=aarch64-linux-gnu-ar CFLAGS="-O2 -g -gdwarf-4 -static -Wno-unused-result" ./configure --disable-rdma --disable-shared --disable-usb \
		--disable-netmap --disable-bluetooth --disable-dbus --without-libnl \
		--without-dpdk --without-dag --without-septel --without-snf \
		--without-gcc --with-pcap=linux \
		--without-turbocap --host=aarch64-unknown-linux-gnu && \
CC=aarch64-linux-gnu-gcc AR=aarch64-linux-gnu-ar make
checking build system type... x86_64-pc-linux-gnu
checking host system type... aarch64-unknown-linux-gnu
checking target system type... aarch64-unknown-linux-gnu
checking for aarch64-unknown-linux-gnu-gcc... aarch64-linux-gnu-gcc
checking whether the C compiler works... no
configure: error: in `/home/runner/work/ecapture/ecapture/lib/libpcap':
configure: error: C compiler cannot create executables
See `config.log' for more details
make[1]: *** [Makefile:201: lib/libpcap.a] Error 77
cp: cannot stat './bin/ecapture': No such file or directory

PR Type

Bug fix


Description

  • Fixed cross-compilation environment setup in GitHub Actions by allowing recommended package dependencies to be installed
  • Addresses the C compiler error during arm64 release builds by ensuring all necessary build dependencies are available

Changes walkthrough 📝

Relevant files
Configuration changes
release.yml
Update package installation flags in GitHub Actions workflow

.github/workflows/release.yml

  • Modified apt-get install command by removing the
    --no-install-recommends flag to ensure all necessary dependencies are
    installed for cross-compilation
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @cfc4n cfc4n added the 🐞 bug Something isn't working label Dec 28, 2024
    @cfc4n cfc4n merged commit 5cc3b54 into gojue:master Dec 29, 2024
    6 checks passed
    @cfc4n
    Copy link
    Member Author

    cfc4n commented Dec 29, 2024

    /review

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @cfc4n
    Copy link
    Member Author

    cfc4n commented Dec 29, 2024

    @CodiumAI-Agent ...

    @cfc4n
    Copy link
    Member Author

    cfc4n commented Dec 29, 2024

    /describe

    Copy link

    PR Description updated to latest commit (70220c8)

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    🐞 bug Something isn't working Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant