Skip to content

Commit

Permalink
sweet: remove biogo benchmarks from default set
Browse files Browse the repository at this point in the history
These benchmarks have shown themselves to not be of a lot of use over
time. They tend to exhibit pathological behaviors not visible in other
programs, that could be worked around if the benchmarks themselves were
improved. Note that these benchmarks are, in part, written by us, using
the biogo library.

biogo-igor is also causing flaky test failures, so this CL skips them for
the end-to-end test, though we think it might be a real PGO bug.

Let's drop them at this point. We'll add back something more interesting
very soon.

Fixes golang/go#56958.
Updates golang/go#69614.

Change-Id: Ic3761953abf4c8db19b3623e135a809c841cf160
Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/615416
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
  • Loading branch information
mknyszek committed Sep 24, 2024
1 parent fdb6f75 commit 7f91281
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions sweet/cmd/sweet/benchmark.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ var benchmarkGroups = func() map[string][]*benchmark {
m := make(map[string][]*benchmark)

m["default"] = []*benchmark{
allBenchmarksMap["biogo-igor"],
allBenchmarksMap["biogo-krishna"],
allBenchmarksMap["bleve-index"],
allBenchmarksMap["cockroachdb"],
allBenchmarksMap["etcd"],
Expand Down
2 changes: 0 additions & 2 deletions sweet/cmd/sweet/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,6 @@ func TestSweetEndToEnd(t *testing.T) {
for i, shard := range []shard{
{"tile38", 2},
{"go-build", 4},
{"biogo-igor", 1},
{"biogo-krishna", 1},
{"cockroachdb", 1},
{"etcd", 1},
{"bleve-index", 1},
Expand Down

0 comments on commit 7f91281

Please sign in to comment.