Skip to content

refactor: rely on requests with ctx #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gdbranco wants to merge 1 commit into from
Closed

refactor: rely on requests with ctx #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion google/downscope/downscoping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,12 @@ func (dts downscopingTokenSource) Token() (*oauth2.Token, error) {
form.Add("options", string(b))

myClient := oauth2.NewClient(dts.ctx, nil)
resp, err := myClient.PostForm(dts.identityBindingEndpoint, form)
req, err := http.NewRequestWithContext(dts.ctx, http.MethodPost, dts.identityBindingEndpoint, strings.NewReader(form.Encode()))
if err != nil {
return nil, err
}
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
resp, err := myClient.Do(req)
if err != nil {
return nil, fmt.Errorf("unable to generate POST Request %v", err)
}
Expand Down
7 changes: 6 additions & 1 deletion jira/jira.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,12 @@ func (js jwtSource) Token() (*oauth2.Token, error) {

// Fetch access token from auth server
hc := oauth2.NewClient(js.ctx, nil)
resp, err := hc.PostForm(js.conf.Endpoint.TokenURL, v)
req, err := http.NewRequestWithContext(js.ctx, http.MethodPost, js.conf.Endpoint.TokenURL, strings.NewReader(v.Encode()))
if err != nil {
return nil, err
}
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
resp, err := hc.Do(req)
if err != nil {
return nil, fmt.Errorf("oauth2: cannot fetch token: %v", err)
}
Expand Down
7 changes: 6 additions & 1 deletion jwt/jwt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,12 @@ func (js jwtSource) Token() (*oauth2.Token, error) {
v := url.Values{}
v.Set("grant_type", defaultGrantType)
v.Set("assertion", payload)
resp, err := hc.PostForm(js.conf.TokenURL, v)
req, err := http.NewRequestWithContext(js.ctx, http.MethodPost, js.conf.TokenURL, strings.NewReader(v.Encode()))
if err != nil {
return nil, err
}
req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
resp, err := hc.Do(req)
if err != nil {
return nil, fmt.Errorf("oauth2: cannot fetch token: %v", err)
}
Expand Down