Fix absolute path includes from a subdir #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves gollum/gollum#1978
As gollum/gollum#1978 explains, include tags with an absolute path currently do not work. The file-to-include is always resolved as the current directory plus the path provided in the tag. This does not work when attempting to include an absolute path in a document in a subidr (the resolved file will then be
"/subdir/absolute/path"instead of"/absolute/path").This PR addresses the issue by checking the include path in order to determine whether it is absolute or not, and only prepending the current directory path in case it is relative.
Many thanks to @aaakbar for identifying the issue and pinpointing the solution!