Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wn-editor as extra package #163

Merged
merged 3 commits into from
Jun 12, 2022
Merged

Add wn-editor as extra package #163

merged 3 commits into from
Jun 12, 2022

Conversation

Hypercookie
Copy link
Contributor

This merge request adds wn-editor as an extra package as discussed in #17.
You can find more information about wn-editor here.

If any changes to wn-editor are required to merge this, please let me know and I will fix them as soon as possible.

Thanks for the good work!

Hypercookie and others added 3 commits May 16, 2022 19:36
This commit adds wn-editor as an extra package to be installed with `pip isntall wn[editor]`
This commit adds wn-editor as an extra package to be installed with `pip install wn[editor]`
@Hypercookie
Copy link
Contributor Author

@goodmami
I dont want to pressure you! Just asking if this will be possible at all.
Thanks!

@goodmami
Copy link
Owner

Sorry, you were right to remind me. I've been sitting on this too long. I've now tested this and there were no issues installing the package. I'll merge the PR.

As a note (perhaps to myself for later), I'm having some second thoughts about using the extras mechanism for installing this. I offered in #17 to use the extra as a way of increasing visibility, but a call-out in the Wn's README would work just as well, or better. Extras, I think, normally install things that enable some optional functionality in the main package instead of another tool (that is, optional dependencies instead of dependents). We can revisit this decision later, e.g., for a 1.0 release.

@goodmami goodmami merged commit 3bcb37b into goodmami:main Jun 12, 2022
@goodmami
Copy link
Owner

The failing lint test was not due to this PR. I'll fix it separately.

@Hypercookie
Copy link
Contributor Author

Thanks for merging!
I will keep wn-editor up to date. If anything comes up just ping me somewhere and we will discuss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants