Fix seenGroupNodeIds mismatch with modelGraph nodes data. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_696656783
branch
3 times, most recently
from
fffb801
to
81f65f2
Compare
looks like the `seenGroupNodeIds` data set may contain group node id that does not belong to the current `modelGraph` nodes data, causing the lookup for node from modelGraph returns undefined (NodeA/NodeB), thus the group layer comparison fails. PiperOrigin-RevId: 696682257
copybara-service
bot
force-pushed
the
test_696656783
branch
from
81f65f2
to
ddb4197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix seenGroupNodeIds mismatch with modelGraph nodes data.
looks like the
seenGroupNodeIdsdata set may contain group node id that does not belong to the currentmodelGraphnodes data, causing the lookup for node from modelGraph returns undefined (NodeA/NodeB), thus the group layer comparison fails.