Disable the treescope renderer test temporarily as it breaks if JAX key classes change. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…ey classes change. PiperOrigin-RevId: 700099059
|
@IvyZX I just saw this! Could you share more details about what breaks here? |
Hi, you should be able to repro by updating to the latest jaxlib and jax and run the test again - the class definition of GetAttrKey changed and thus there are some random comments on each rendered line which breaks the test. |
|
I've added handler support for the new pytree classes in Treescope v0.1.7, and this test now passes with latest jaxlib/jax. I'll close this since I think merging it is no longer necessary. Hopefully this didn't block anything on your end, and feel free to comment or reopen if I've missed something! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the treescope renderer test temporarily as it breaks if JAX key classes change.