no need to copy objects when annotated#27
no need to copy objects when annotated#27William-Baker wants to merge 3 commits intogoogle-deepmind:mainfrom
Conversation
david-lindner
left a comment
There was a problem hiding this comment.
I suppose this does not improve the compilation performance but your program generation code? How large is the speedup?
I'm slightly hesitant about this change because it looks like something that might introduce silent bugs. I have to think a bit more whether something can break here.
If we make this change: we can also remove .copy and the dependency on copy.
|
I've modified the doc string and removed the copy methods and dependency, at the time of removing this, it took around 30% of compilation time just on copy operations, however some were large programs |
david-lindner
left a comment
There was a problem hiding this comment.
rasp_test currently fails -- pls fix before merging
|
I have removed the tests for copy() and copying when annotating, we could always keep the copy method and keep the copy tests? |
david-lindner
left a comment
There was a problem hiding this comment.
Still makes rasp_to_craft_integration_test fail in a bunch of places. Can you look into this?
Also, can you please run all the tests in the future before making a PR? Thanks!
No need to copy annotations, this is expensive