Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This test is really sloppy. We'll need to fix it. #572

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

This test is really sloppy. We'll need to fix it. #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 32 additions & 20 deletions tests/test_async_code_match.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,38 +73,50 @@ def _execute_code_match(self, source, asource):
.replace("ASYNC_", "")
)
asource = re.sub(" *?# type: ignore", "", asource)
if source != asource:
pass
self.assertEqual(source, asource)

def test_code_match_for_async_methods(self):
for fpath in (pathlib.Path(__file__).parent.parent / "google").rglob("*.py"):
print(fpath)
if fpath.name in EXEMPT_FILES or any([d in fpath.parts for d in EXEMPT_DIRS]):
continue
# print(f"Checking {fpath.absolute()}")
code_match_funcs: dict[str, ast.AST] = {}
funcs: dict[str, ast.AST] = {}
async_funcs: dict[str, ast.AST] = {}
source = fpath.read_text()
source_nodes = ast.parse(source)

for node in ast.walk(source_nodes):
if isinstance(
node, (ast.FunctionDef, ast.AsyncFunctionDef)
) and not node.name.startswith("__"):
name = node.name[:-6] if node.name.endswith("_async") else node.name
if name in EXEMPT_FUNCTIONS or self._inspect_decorator_exemption(node, fpath):
continue
# print(f"Checking {node.name}")

if func_name := code_match_funcs.pop(name, None):
snode, anode = (
(func_name, node)
if isinstance(node, ast.AsyncFunctionDef)
else (node, func_name)
)
func_source = self._maybe_trim_docstring(snode)
func_asource = self._maybe_trim_docstring(anode)
self._execute_code_match(func_source, func_asource)
# print(f"Matched {node.name}")


if not isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef)):
continue
if node.name.startswith("__"):
continue

if isinstance(node, ast.AsyncFunctionDef):
is_async = True
code_match_funcs = funcs
else:
is_async = False
code_match_funcs = async_funcs

name = node.name.removesuffix("_async")
if name in EXEMPT_FUNCTIONS or self._inspect_decorator_exemption(node, fpath):
continue

if matched_node := code_match_funcs.pop(name, None):
if is_async:
snode, anode = (matched_node, node)
else:
code_match_funcs[node.name] = node
anode, snode = (matched_node, node)
func_source = self._maybe_trim_docstring(snode)
func_asource = self._maybe_trim_docstring(anode)
self._execute_code_match(func_source, func_asource)
else:
code_match_funcs[node.name] = node


if __name__ == "__main__":
Expand Down
Loading