Redefine NameMapE as the primitive type #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step in de-duplicating the NameMap and NameMapE APIs.
…pE applied to LiftE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And define
NameMapas a type alias for aNameMapEof aLiftEtype. This follows a rationale (included) for whyNameMapE(with the type it has) is the data structure you want for bottom-up traversals.The reason to make
NameMapan alias is to avoid duplicating the API surface between the two maps, so that it's not such a pain to eventually cover the entire API ofData.Mapin theNameMapEAPI.