Skip to content

Fixed ResolvedMap to be compatible with primitives, like StringValue #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
btw17 wants to merge 1 commit into from
+1 −1
Closed

Fixed ResolvedMap to be compatible with primitives, like StringValue #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion renderers/web_core/src/v0_8/types/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ export type ResolvedValue =
| ResolvedArray;

/** A generic map where each value has been recursively resolved. */
export type ResolvedMap = { [key: string]: ResolvedValue };
export type ResolvedMap = { [key: string]?: ResolvedValue };
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change does not fix the underlying type issue. An object with optional properties (e.g., prop?: T) is not assignable to {[key: string]?: T} because the type of the optional property is T | undefined, which is not assignable to T. In this case, ResolvedValue does not include undefined.

To correctly fix the type assignability for objects with optional properties, the value type of the index signature must include undefined.

While this is a significant change to the type definition, it appears safe with respect to the current implementation of resolvePropertyValue, which does not produce undefined values. This change is necessary to correctly type the relationship between primitive objects with optional fields and ResolvedMap.

Suggested change
export type ResolvedMap = { [key: string]?: ResolvedValue };
export type ResolvedMap = { [key: string]: ResolvedValue | undefined };


/** A generic array where each item has been recursively resolved. */
export type ResolvedArray = ResolvedValue[];
Expand Down
Loading