Skip to content

Conversation

@sugoi-yuzuru
Copy link
Collaborator

…o NOT get transformed by minification JS.

Description

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the declare keyword to many exported types and interfaces in renderers/web_core/src/v0_8/types/types.ts. The stated goal is to prevent these from being transformed by JavaScript minification, which is a valid approach for preserving a public API. While the changes themselves are syntactically correct, the refactoring appears to be incomplete. Other exported types, both within this file (e.g., MessageProcessor) and in related files (components.ts, client-event.ts), have not been updated. This inconsistency could lead to unexpected behavior and maintenance issues. I recommend applying this change consistently across all public API types for this library.

@gspencergoog gspencergoog merged commit db3b335 into main Feb 11, 2026
10 checks passed
@gspencergoog gspencergoog deleted the declare_types branch February 11, 2026 19:55
@github-project-automation github-project-automation bot moved this from Todo to Done in A2UI Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants