-
Notifications
You must be signed in to change notification settings - Fork 2k
Feat/expose mcps streamable http custom httpx factory parameter #2997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/expose mcps streamable http custom httpx factory parameter #2997
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @mikeedjones, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Response from ADK Triaging Agent Hello @mikeedjones, thank you for your contribution! To help our reviewers, could you please add a You can find more details in our contribution guidelines. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully exposes the httpx_client_factory
parameter for StreamableHTTPConnectionParams
, allowing for greater control over the internal httpx
client. The implementation is clean and the inclusion of a test case is appreciated. I've provided a couple of minor suggestions to improve code style and align the new test with unit testing best practices.
5b70475
to
8ab74cc
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
8ab74cc
to
a1fcb65
Compare
…x-factory-parameter
…x-factory-parameter
… test_init_with_streamable_http_default_httpx_factory for clarity
…x-factory-parameter
This PR addresses #3005 and #2963 to allow control over the ssl cert used when connecting to an mcp server by exposing the
httpx_client_factory
parameter exposed when creating aMCPSessionManager
in adk. Overlaps with #2966 but I don't believe that that PR's implementation will work.streamablehttp_client
needs a client factory, not a client.testing plan
Adds test checking that
streamablehttp_client
uses the custom httpx factory. Could also test that a factory which obeys theMcpHttpClientFactory
protocol produces valid behavior when the session is opened?related issues
#2227 and #2881 both request slightly different options to control the ssl certs used internally by adk. I think exposing a httpx factory is a good pattern which could be followed for those issues too.