feature: support restarting bidi streaming #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi thank you for this, do you mind resolve the conflict here? I can review this PR |
jinnigu
force-pushed
the
support-restarting-bidi
branch
from
723fe10 to
e01713e
Compare
Author
Hi @wyf7107 , I resolved the conflict. Do you mind help take another look when you are available? Thank you! |
Collaborator
|
Taking a look ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where users couldn't restart audio/video streaming after stopping it in the same session. Previously, clicking the microphone icon after stopping would show an error "Restarting bidirectional streaming is not currently supported", forcing users to refresh the page.
The fix clears the session tracking when users stop recording and cleans up/recreates the AudioContext on reconnection, allowing users to start, stop, and restart streaming within the same session.
Fix #119