Skip to content

Commit

Permalink
Delete the VS2017 directories
Browse files Browse the repository at this point in the history
Pass the visual studio version to the windows build script

Change-Id: I1cf21ed387a52f4a260211be9964d84dc446d2f4
  • Loading branch information
dneto0 committed Dec 23, 2024
1 parent fea0be7 commit 95af7c1
Show file tree
Hide file tree
Showing 9 changed files with 8 additions and 104 deletions.
7 changes: 5 additions & 2 deletions kokoro/scripts/windows/build.bat
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
set BUILD_ROOT=%cd%
set SRC=%cd%\github\amber
set BUILD_TYPE=%1
set VS_VERSION=%2

:: Force usage of python 3.12
set PATH=C:\python312;%PATH%
Expand All @@ -29,8 +30,10 @@ python tools\git-sync-deps
:: #########################################
:: set up msvc build env
:: #########################################
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" x64
echo "Using VS 2019..."
if %VS_VERSION% == 2019 (
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" x64
echo "Using VS 2019..."
)

cmake --version

Expand Down
20 changes: 0 additions & 20 deletions kokoro/windows-msvc-2017-debug/build.bat

This file was deleted.

15 changes: 0 additions & 15 deletions kokoro/windows-msvc-2017-debug/continuous.cfg

This file was deleted.

15 changes: 0 additions & 15 deletions kokoro/windows-msvc-2017-debug/presubmit.cfg

This file was deleted.

20 changes: 0 additions & 20 deletions kokoro/windows-msvc-2017-release/build.bat

This file was deleted.

15 changes: 0 additions & 15 deletions kokoro/windows-msvc-2017-release/continuous.cfg

This file was deleted.

15 changes: 0 additions & 15 deletions kokoro/windows-msvc-2017-release/presubmit.cfg

This file was deleted.

2 changes: 1 addition & 1 deletion kokoro/windows-msvc-2019-debug/build.bat
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
:: Find the directory of the common build script.
set SCRIPT_DIR=%~dp0

call %SCRIPT_DIR%\..\scripts\windows\build.bat Debug
call %SCRIPT_DIR%\..\scripts\windows\build.bat Debug 2019
3 changes: 2 additions & 1 deletion kokoro/windows-msvc-2019-release/build.bat
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@
:: Find the directory of the common build script.
set SCRIPT_DIR=%~dp0

call %SCRIPT_DIR%\..\scripts\windows\build.bat RelWithDebInfo
call %SCRIPT_DIR%\..\scripts\windows\build.bat RelWithDebInfo 2019

0 comments on commit 95af7c1

Please sign in to comment.