set cmake_minimum_required to 3.22 #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj2
approved these changes
Dec 23, 2024
|
The MSVC 2017 configs are invalid now, and have been deleted on the Kokoro config side internal to Google |
That's the cmake verion included in Ubuntu 2022.04 Change-Id: I5d6da0d33c86eae5020bba1b9a8805fc8d7e7868
|
The MSVC failures seem to be related to:
|
Assume old-style setting of MSVC runtime selection. See https://cmake.org/cmake/help/latest/policy/CMP0091.html Set to OLD to allow migration of projects to the new mechanism. Change-Id: I29f78d11e912924689f5508f1c2d6e72013d2563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's the cmake verion included in Ubuntu 2022.04
Change-Id: I5d6da0d33c86eae5020bba1b9a8805fc8d7e7868