Isolate metrics conversion #1718
Merged
+68
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need to be rebased one #1717 merges |
cjreynol
force-pushed
the
isolate_metrics_conversion
branch
from
092efe5 to
0fa0c21
Compare
cjreynol
added
kokoro:force-run
Databean
approved these changes
Oct 20, 2025
GoogleCuttlefishTesterBot
removed
kokoro:run
Bug: 452437293
Bug: 452437293
Bug: 452437293
Keeping conversion focused on building the proto from the internal representations. Bug: 452437293
Better to use a more semantically accurate type.
cjreynol
force-pushed
the
isolate_metrics_conversion
branch
from
0fa0c21 to
67bfd50
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy over and modify the v1 metrics logic. This lets us make modifications without worrying about breaking v1 metrics logic. Eventually, the v1 logic will be removed in favor of this new code.
Bug: 452437293