Download super image fragments with a new flag #1738
Merged
+145
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemoreira
approved these changes
Oct 23, 2025
Databean
force-pushed
the
download_super_info
branch
2 times, most recently
from
8f4d796 to
99d4fe8
Compare
|
Thanks for reviewing! |
This enables a new flow to download the super image components out of the target_files zip, using a path that only downloads the fragments of the zip necessary. Downloading the super image fragments is comparable to downloading the image zip, but these files can be used to build a super image ourselves with any last-minute modifications we need. Some performance and correctness improvements in the partial zip download are included in this change: increasing the chunk size for partial downloads, and working around libzip doing read-all behavior from its read calls. The partial zip download takes twice the time of the full image zip download, so hopefully more performance improvements are possible afterward. This change also supersedes google#1558 . Bug: b/439877215
Databean
force-pushed
the
download_super_info
branch
from
99d4fe8 to
1f60a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new flag
--extract_super_image_fragmentstocvd fetch.This enables a new flow to download the super image components out of the target_files zip, using a path that only downloads the fragments of the zip necessary.
Downloading the super image fragments is comparable to downloading the image zip, but these files can be used to build a super image ourselves with any last-minute modifications we need.
Some performance and correctness improvements in the partial zip download are included in this change: increasing the chunk size for partial downloads, and working around libzip doing read-all behavior from its read calls. The partial zip download takes twice the time of the full image zip download, so hopefully more performance improvements are possible afterward.
This change also supersedes #1558 .
Bug: b/439877215