This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Don’t call gem #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `lib/compat/multi_json.rb` there is a call to `Kernel#gem`. Normally these things will be handled by Bundler so it is unclear why this is here. This causes a problem when using https://github.com/iconara/puck since it doesn’t actually include gem specs but sets up required gems statically in a jar-file, causing the call to fail. The solution is to simply remove that call.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
lib/compat/multi_json.rbthere is a call toKernel#gem. Normally these things will be handled by Bundler so it is unclear why this is here.This causes a problem when using https://github.com/iconara/puck since it doesn’t actually include gem specs but sets up required gems statically in a jar-file, causing the call to fail.
The solution is to simply remove that call.