Skip to content

Commit

Permalink
Remove redundant tests.
Browse files Browse the repository at this point in the history
Change-Id: I23c44ae5896eb9f96bbfba1af0374b2a9aaeb2e5
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/72728
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
  • Loading branch information
nharper authored and Boringssl LUCI CQ committed Nov 3, 2024
1 parent 9647280 commit ddc0647
Showing 1 changed file with 0 additions and 33 deletions.
33 changes: 0 additions & 33 deletions ssl/test/runner/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -5200,39 +5200,6 @@ func addStateMachineCoverageTests(config stateMachineTestConfig) {
flags: []string{"-expect-hrr"},
})

// TODO(crbug.com/42290594): The -NoResume tests here are copies
// of the above tests, but without resumeSession set. These exist to
// test HRR in DTLS 1.3, because tests DTLS 1.3 tests with resumption
// enabled are skipped due to lack of support for resumption. Once we
// support resumption in DTLS 1.3, these can be deleted.
if config.protocol == dtls {
tests = append(tests, testCase{
name: "TLS13-HelloRetryRequest-Client-NoResume",
config: Config{
MaxVersion: VersionTLS13,
MinVersion: VersionTLS13,
// P-384 requires a HelloRetryRequest against BoringSSL's default
// configuration. Assert this with ExpectMissingKeyShare.
CurvePreferences: []CurveID{CurveP384},
Bugs: ProtocolBugs{
ExpectMissingKeyShare: true,
},
},
flags: []string{"-expect-hrr"},
})
tests = append(tests, testCase{
testType: serverTest,
name: "TLS13-HelloRetryRequest-Server-NoResume",
config: Config{
MaxVersion: VersionTLS13,
MinVersion: VersionTLS13,
// Require a HelloRetryRequest for every curve.
DefaultCurves: []CurveID{},
},
flags: []string{"-expect-hrr"},
})
}

// TLS 1.3 early data tests. DTLS 1.3 doesn't support early data yet.
// These tests are disabled for QUIC as well because they test features
// that do not apply to QUIC's use of TLS 1.3.
Expand Down

0 comments on commit ddc0647

Please sign in to comment.