Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support accelerator flag in cli and cvdr.toml #403

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Support accelerator flag in cli and cvdr.toml #403

merged 1 commit into from
Jan 24, 2025

Conversation

yippyyipyip
Copy link
Contributor

No description provided.

ser-io
ser-io requested changes Jan 17, 2025
View reviewed changes
pkg/cli/cli.go Outdated Show resolved Hide resolved
pkg/cli/cli.go Outdated Show resolved Hide resolved
pkg/cli/cli.go Outdated Show resolved Hide resolved
pkg/cli/cli.go Outdated Show resolved Hide resolved
ser-io
ser-io requested changes Jan 21, 2025
View reviewed changes
pkg/cli/cli.go Outdated Show resolved Hide resolved
@yippyyipyip yippyyipyip marked this pull request as ready for review January 22, 2025 20:14
@yippyyipyip yippyyipyip requested a review from ser-io January 22, 2025 20:46
@yippyyipyip yippyyipyip force-pushed the updated-config branch 2 times, most recently from 0c0b7ed to 1ae3953 Compare January 22, 2025 22:31
@yippyyipyip yippyyipyip changed the title Support accelerator and boot disk size in cvdr.toml Support accelerator flag in cli and cvdr.toml Jan 22, 2025
@ser-io ser-io enabled auto-merge January 23, 2025 16:49
auto-merge was automatically disabled January 23, 2025 18:55

Head branch was pushed to by a user without write access

ser-io
ser-io requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@ser-io ser-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have only 1 commit.

Updating the TestLoadFullConfig should be part of the initial commit as well to avoid a misleading failure when performing a git bisection.

@ser-io ser-io enabled auto-merge January 23, 2025 21:52
@yippyyipyip
Added accelerator flag to cli and cvdr.toml
78e1ce9 
Signed-off-by: Johnny Yip <jcyip@google.com>
auto-merge was automatically disabled January 23, 2025 21:58

Head branch was pushed to by a user without write access

@yippyyipyip
Copy link
Contributor Author

Fixed gofmt error

@ser-io ser-io added this pull request to the merge queue Jan 24, 2025
Merged via the queue into google:main with commit 0c20352 Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ser-io ser-io ser-io approved these changes

@jemoreira jemoreira Awaiting requested review from jemoreira jemoreira is a code owner

@jmacnak jmacnak Awaiting requested review from jmacnak jmacnak is a code owner

@rmuthiah rmuthiah Awaiting requested review from rmuthiah rmuthiah is a code owner

@adelva1984 adelva1984 Awaiting requested review from adelva1984 adelva1984 is a code owner

@Databean Databean Awaiting requested review from Databean Databean is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yippyyipyip @ser-io