Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webUSB #137

Merged
merged 2 commits into from
Nov 8, 2023
Merged

remove webUSB #137

merged 2 commits into from
Nov 8, 2023

Conversation

wtrgjadmw
Copy link
Collaborator

This PR removes "Start (webUSB)" button to make the codes simpler.
It was implemented to support MacOS, which doesn't support communication via WebSerial. But for now, we are focusing on ChromeOS as a workstation and DUT, so it can be removed.
If MacOS is needed for the future, you can reproduce the codes from git log.

Copy link
Collaborator

@hikalium hikalium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hikalium hikalium merged commit d4006a6 into google:main Nov 8, 2023
@mblsha
Copy link

mblsha commented Nov 15, 2023

Seems that the message needs to be updated, since webUSB is removed.
Screenshot 2023-11-15 at 12 02 24 pm

@mblsha
Copy link

mblsha commented Nov 20, 2023

Turns out after this change it won't work on macOS anymore since it doesn't have a driver that would expose Servo's serial ports in a way that would be visible by Chrome.

@wtrgjadmw
Copy link
Collaborator Author

The tool aims to support the power consumption measurement of a Chromebook for now, so we deleted this to avoid the code structure becoming too complicated. But it is still future work to support webUSB connection again.

@cynthia
Copy link
Collaborator

cynthia commented Nov 20, 2023

I personally think this should be reverted and reworked so that it does WebSerial on ChromeOS/Linux and WebUSB elsewhere. I suspect the Windows path also needs WebUSB, which is likely what our partners would be using.

@hikalium
Copy link
Collaborator

Thanks for the feedback everyone! Created #159 to revive the WebUSB support. Please give us some time as our workload is limited. (if you want to work on it, please let me know so that I can re-assign the issue to you!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants