219 cro3 flash recovery should use signed image on usb #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since --recovery flashes a USB recovery image, it should be written in USB flash. If we directly write it to DUT, the DUT will not boot.
mhiramat
requested review from
hikalium,
HidenoriKobayashi,
cynthia and
brandonpollack23
as code owners
mhiramat
force-pushed
the
219-lium-flash-recovery-should-use-signed-image-on-usb
branch
from
e36e859 to
4bae6f8
Compare
|
Updated according to the comment. |
When we recover DUT from bricked state, we need to use signed image instead of unsigned one. Use "signed" recovery image for making a recovery USB flash.
mhiramat
force-pushed
the
219-lium-flash-recovery-should-use-signed-image-on-usb
branch
from
4bae6f8 to
1075918
Compare
|
fix a style problem. |
hikalium
approved these changes
Apr 10, 2024
hikalium
deleted the
219-lium-flash-recovery-should-use-signed-image-on-usb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cro3 flash uses signed recovery image and it requires --usb option.