Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #243

Merged
merged 13 commits into from
May 1, 2024
Merged

Various fixes #243

merged 13 commits into from
May 1, 2024

Conversation

hikalium
Copy link
Collaborator

List of the changes:

Fixup clippy warnings to pass make commit
Update docs to pass make test
Automatically start ssh forwarding for chrooted commands
Try re-adding the reused addr on cro3 dut list --update
fixup setup commands
Make sure if we have gsutil and gcloud, and it is authenticated
Set stdin null when running repo sync to avoid interactive prompts

@HidenoriKobayashi
Copy link
Collaborator

Looking at the change for the sh file, how about we run shellcheck on all of them?

@hikalium
Copy link
Collaborator Author

@HidenoriKobayashi enabled shellcheck and shfmt for all *.sh and *.bash files! Please take a look again!

@hikalium
Copy link
Collaborator Author

@HidenoriKobayashi Please take a look when you have a time. Thank you!

Copy link
Collaborator

@HidenoriKobayashi HidenoriKobayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for integrating the shellcheck check.

Copy link
Collaborator

@mhiramat mhiramat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the cro3.bash part looks good to me.
Thanks!

@mhiramat mhiramat merged commit 5f036d1 into main May 1, 2024
3 checks passed
@mhiramat mhiramat deleted the zero_setup_workflow_fix branch May 1, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants