Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip the default for explicitBindingConflictsWithInject to enabled. #4183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

copybara-service[bot]
Copy link

Flip the default for explicitBindingConflictsWithInject to enabled.

RELNOTES=Flip the default for explicitBindingConflictsWithInject to error

RELNOTES=Flip the default for explicitBindingConflictsWithInject to error
PiperOrigin-RevId: 297153765
@@ -404,7 +404,7 @@ public ImmutableList<String> aliases() {
* How to report that an explicit binding in a subcomponent conflicts with an {@code @Inject}
* constructor used in an ancestor component.
*/
EXPLICIT_BINDING_CONFLICTS_WITH_INJECT(WARNING, ERROR, NONE),
EXPLICIT_BINDING_CONFLICTS_WITH_INJECT(ERROR, WARNING, NONE),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would this matter?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order changes the default value -- the first value passed to the enum's constructor is the default value.

@ergutierz
Copy link

ergutierz commented Dec 16, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants