Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new sensor & meters #1092

Merged
merged 36 commits into from
Oct 4, 2023
Merged

Conversation

adelin-diac
Copy link
Contributor

@adelin-diac adelin-diac commented Jul 21, 2023

No description provided.

@adelin-diac adelin-diac marked this pull request as ready for review July 24, 2023 14:33
@cstirdivant cstirdivant self-requested a review July 24, 2023 17:06
ontology/yaml/resources/METERS/entity_types/WM.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/subfields/subfields.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/fields/telemetry_fields.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/HVAC/entity_types/SENSOR.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/subfields/subfields.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/HVAC/entity_types/SENSOR.yaml Outdated Show resolved Hide resolved
@adelin-diac adelin-diac removed their assignment Aug 14, 2023
ontology/yaml/resources/fields/telemetry_fields.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/subfields/subfields.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/units/units.yaml Show resolved Hide resolved
ontology/yaml/resources/fields/telemetry_fields.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/HVAC/entity_types/SENSOR.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/HVAC/entity_types/SENSOR.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/HVAC/entity_types/SENSOR.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/HVAC/entity_types/SENSOR.yaml Outdated Show resolved Hide resolved
ontology/yaml/resources/HVAC/entity_types/SENSOR.yaml Outdated Show resolved Hide resolved
@kevin-hereworks
Copy link
Contributor

kevin-hereworks commented Sep 26, 2023

hi @cstirdivant would you be able to re review this when you get a chance? Should be all fixed.

Regarding the tamper alarm i believe it is a switch based on the case being opened

@cstirdivant cstirdivant merged commit bb1251c into google:master Oct 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants