Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of a new HWS. #1158

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Addition of a new HWS. #1158

merged 7 commits into from
Dec 5, 2023

Conversation

ghairapetian
Copy link
Contributor

No description provided.

@cstirdivant cstirdivant self-requested a review October 5, 2023 18:11
@ghairapetian
Copy link
Contributor Author

Correction done. I modified the type so I use SWTC and a valve function.

@cstirdivant
Copy link
Collaborator

Hi @ghairapetian thank you for the additional information, based on this, it is most-correct to model the valve as a mixing valve. See the abstract type MXVPM for an example. (If you have both the valve percentage command and percentage sensor, please add the sensor as opt_uses).

@ghairapetian
Copy link
Contributor Author

Hi @cstirdivant , I added the mixed_valve_percentage_sensor point and I removed the new type because HWS_SWTC_MXVPM already exists

@cstirdivant cstirdivant self-assigned this Dec 5, 2023
@cstirdivant cstirdivant merged commit 005eb84 into google:master Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstirdivant cstirdivant cstirdivant approved these changes

Assignees

@cstirdivant cstirdivant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghairapetian @cstirdivant