Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elevate PMP and VLV to the global namespace #1330

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

elevate PMP and VLV to the global namespace #1330

wants to merge 3 commits into from

Conversation

cstirdivant
Copy link
Collaborator

@cstirdivant cstirdivant commented May 2, 2024 •
edited
Loading

Elevating PMP and VLV general types to the global namespace

  • removing namespace-level defs for PMP and VLV from HVAC and PLUMBING
  • revising canonical types to inherit from the global namespace
  • removing un-used non-canonical types in HVAC/PMP.yaml

shambergoldstein
shambergoldstein reviewed Sep 5, 2024
View reviewed changes
ontology/yaml/resources/HVAC/entity_types/PMP.yaml
### Existing Non-standard Types ###
###################################

PMP_SS_VSC_NONCANONICAL_1:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type is used by two real world devices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shambergoldstein shambergoldstein shambergoldstein left review comments

@tasodorff tasodorff Awaiting requested review from tasodorff

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cstirdivant @shambergoldstein