Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming unused measurements to accurate names + removing superfluous apparent on power/energy #1348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ohshazbot
Copy link
Contributor

  • electricfield already exists in the ontology with the unit (V/m) and magnetic field strength measures (A/m).
  • Apparent power and energy sensors use kilo_volt_ampere and kilo_volt_ampere_hours respectively so we don’t need the explicit apparent units
  • joules_per_kilogram_kelvin is a measure of entropy.

Copy link

google-cla bot commented May 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cstirdivant cstirdivant self-assigned this Jun 4, 2024
@ohshazbot
Copy link
Contributor Author

Hmm, I'll have to look into those validation failures

@ohshazbot ohshazbot force-pushed the measurement-tidying branch 2 times, most recently from ceae871 to f8210d4 Compare June 5, 2024 18:58
@ohshazbot ohshazbot force-pushed the measurement-tidying branch from f8210d4 to 22a8853 Compare June 7, 2024 16:36
@cstirdivant cstirdivant removed their assignment Sep 4, 2024
@cstirdivant cstirdivant added the breaking_change The pull request contains a backwards incompatible change label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change The pull request contains a backwards incompatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants