-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create new types for taiwan project #1384
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@terryterpt I am pausing my review until you address a few things across this PR:
|
@cstirdivant , I have rectify the following items, please help to review my commit again.
|
tools/guid_generator/instance/instance_guid_generator/generator.py
Outdated
Show resolved
Hide resolved
Terry, The PR name and description still has the building specific name, please remove. In general, this PR is not acceptable.
|
Hi @cstirdivant , I have done the following:
|
Hi @cstirdivant , please help to review my commit again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay on this review.
In order to omit the python file changes from the PR you must restore them to their original contents rather than deleting them.
tools/guid_generator/instance/instance_guid_generator/generator.py
Outdated
Show resolved
Hide resolved
I have the CH type CH_SS_CC2XM_REFSM2X_REFPM2X with the setpoint that is indeed hidden in the BMS system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only yaml files should be in the PR, please remove any others
@shambergoldstein , I have removed the files that are not Yaml |
Hi, I am terry from Primustech MSI and currently doing the DBO for the new Google project in Taiwan.
I am creating this pull request to add entity and abstract types for this project.