new_sensor_type_with_ZOC #1470
Merged
new_sensor_type_with_ZOC #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shambergoldstein
approved these changes
Nov 26, 2024
shambergoldstein
requested changes
Nov 26, 2024
| @@ -34,6 +34,24 @@ SENSOR_ZTM_ZHM_CO2M_VOCM_PMDM_SPLM_ZAQIM_ZSPM_ZWVDM: | |||
| uses: | |||
| - illuminance_sensor | |||
|
|
|||
| SENSOR_ZTM_ZHM_CO2M_VOCM_PMDM_SPLM_ZAQIM_ZSPM_ZOC: | |||
There was a problem hiding this comment.
please fix tabbing here
There was a problem hiding this comment.
Could you provide more clarification?
Should ZOC be added to SENSOR_ZTM_ZHM_CO2M_VOCM_PMDM_SPLM_ZAQIM_ZSPM_ZWVDM existing entity type?
There was a problem hiding this comment.
I just mean that the canonical type name is indented/has extra spacing before it
There was a problem hiding this comment.
Hi @shambergoldstein , thanks for getting back to me on that.
shambergoldstein
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.