Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New devices HDS, WSR, etc #794
New devices HDS, WSR, etc #794
Changes from 100 commits
5c86108
a818cfc
e7586b7
9d98f73
f533bbe
f011703
589ae2a
96765e1
cc03351
621a570
d38bfe5
12ccc03
5eb1202
4c1f65f
18acfee
854bdce
3eae6ef
76b63b5
a7d2b73
dacebaf
63beea3
38c2837
0e12995
5e58c4d
cf20284
072f958
cd0971c
8cec630
3614d43
ed3c2ac
e3e92bc
83ba6d5
30156b2
eb234d3
7487046
b54beb1
7121a03
3947b94
e6fac0a
75b52eb
8b8811b
68c239e
8396828
96769ed
e41cd00
1262370
247ce3c
2e01e81
4529e45
752cf9c
df3284e
4093d4c
8a6d8fb
900fa5a
ccbd2c6
fa67e61
8b27de1
dabf5cf
eec6adf
4419fd8
7f95422
c40a34e
594b1bd
452bc49
7fdf7bb
ee0ffa9
fca33e9
cef41ff
a6749b2
a47fb6d
8745d67
9382c73
dd586de
542733d
10a4c0b
8f9724d
53ecea6
86ca682
8c65ded
6ec4f40
ee70bb7
ace05ad
b0cb7f2
1719259
32ac6b8
ded801f
fd6f343
5609518
f33e281
42e7b3e
71d21c8
99350fc
799d7a2
7add5c5
98fdaac
5f49c9a
7870166
9cf80c6
2b4d3ae
1567954
d44238c
769e32b
659c76f
32e6327
484d6cd
2a48c9e
d0cc749
93e0fca
b884673
36e38cc
d4fcc25
2c7d332
afba10f
4b31179
7eab65c
eab0edd
4858175
21e1343
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the system have different responses at each level of alarm (in other words, is the system response for a
low_smoke_alarm
different from the response to ahigh_smoke_alarm
?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, ma'am. for low smoke BMS has a warning alert on PC. (There is no high smoke this is equivalent to fire alarm) for fire alarm, siren is on. For medium smoke, not sure, I'll ask the BMS team for that, will report back on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that makes sense. I Notice here this type only has opt_uses (which is not best-practice). In this case, I suggest deleting the
ASD
type completely and simply defining these fields on the FACP_ASD type directlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted ma'am, removed ASD now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This panel alarm probably belongs on an FACP type instead. Everything else on this type is reasonable, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would need help to rename this point because it is a general alarm, a catch-all alarm if there is something wrong other than fire or power fail. the description for this was supervisor alarm, in which when it's on a supervisor for the device could check things out. my few suggestions could be:
these are not in subfields yet:
any more suggestions ma'am?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using
master_alarm
to model this catch-all alarmThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted ma'am. Replaced failed panel alarm to master alarm now