Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New devices HDS, WSR, etc #794

Merged
merged 118 commits into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from 100 commits
Commits
Show all changes
118 commits
Select commit Hold shift + click to select a range
5c86108
initial pull request
josephedwardchang Oct 6, 2022
a818cfc
Merge branch 'master' of https://github.com/josephedwardchang/digital…
josephedwardchang Oct 6, 2022
e7586b7
additional items
josephedwardchang Oct 6, 2022
9d98f73
additional items
josephedwardchang Oct 6, 2022
f533bbe
additional items
josephedwardchang Oct 6, 2022
f011703
Merge branch 'master' into master
josephedwardchang Oct 9, 2022
589ae2a
Merge branch 'master' into master
josephedwardchang Oct 12, 2022
96765e1
Merge branch 'master' into master
josephedwardchang Oct 14, 2022
cc03351
Merge branch 'master' into master
josephedwardchang Oct 14, 2022
621a570
Merge branch 'master' into master
josephedwardchang Oct 20, 2022
d38bfe5
Merge branch 'master' into master
josephedwardchang Oct 24, 2022
12ccc03
Merge branch 'master' into master
josephedwardchang Oct 25, 2022
5eb1202
Merge branch 'master' into master
josephedwardchang Oct 26, 2022
4c1f65f
Merge branch 'master' into master
josephedwardchang Oct 27, 2022
18acfee
Merge branch 'master' into master
josephedwardchang Oct 28, 2022
854bdce
Merge branch 'master' into master
josephedwardchang Nov 1, 2022
3eae6ef
Merge branch 'master' into master
josephedwardchang Nov 5, 2022
76b63b5
Merge branch 'master' into master
josephedwardchang Nov 8, 2022
a7d2b73
Merge branch 'master' into master
josephedwardchang Nov 8, 2022
dacebaf
Merge branch 'master' into master
josephedwardchang Nov 10, 2022
63beea3
updated fixes
josephedwardchang Jan 18, 2023
38c2837
Merge branch 'master' into master
josephedwardchang Jan 18, 2023
0e12995
Merge branch 'master' into master
josephedwardchang Jan 19, 2023
5e58c4d
update minor fixes
josephedwardchang Jan 19, 2023
cf20284
Merge branch 'master' into master
josephedwardchang Jan 23, 2023
072f958
Merge branch 'master' into master
josephedwardchang Jan 25, 2023
cd0971c
Merge branch 'master' into master
josephedwardchang Jan 31, 2023
8cec630
minor update and fixes
josephedwardchang Feb 2, 2023
3614d43
fix merge
josephedwardchang Feb 2, 2023
ed3c2ac
Merge branch 'master' into master
josephedwardchang Feb 9, 2023
e3e92bc
minor update for motorized*
josephedwardchang Feb 9, 2023
83ba6d5
Merge branch 'master' of https://github.com/josephedwardchang/digital…
josephedwardchang Feb 9, 2023
30156b2
minor fix
josephedwardchang Feb 9, 2023
eb234d3
Merge branch 'master' into master
josephedwardchang Feb 22, 2023
7487046
small update unused fields
josephedwardchang Feb 22, 2023
b54beb1
Merge branch 'master' into master
josephedwardchang Mar 6, 2023
7121a03
Merge branch 'master' into master
josephedwardchang Mar 10, 2023
3947b94
fix recent breaking changes
josephedwardchang Mar 10, 2023
e6fac0a
Add GUIDs to new entity types
db-robot Mar 10, 2023
75b52eb
Merge branch 'master' into master
charbull Mar 20, 2023
8b8811b
Merge branch 'master' into master
josephedwardchang Mar 27, 2023
68c239e
Merge branch 'master' into master
josephedwardchang Mar 29, 2023
8396828
update for PR #794 - fixes fire alarms,etc
josephedwardchang Mar 30, 2023
96769ed
Add GUIDs to new entity types
db-robot Mar 30, 2023
e41cd00
Merge branch 'master' into master
josephedwardchang Apr 11, 2023
1262370
Merge branch 'master' into master
josephedwardchang Apr 14, 2023
247ce3c
minor fix on BBM
josephedwardchang Apr 14, 2023
2e01e81
Merge branch 'master' of https://github.com/josephedwardchang/digital…
josephedwardchang Apr 14, 2023
4529e45
Merge branch 'master' into master
josephedwardchang Apr 17, 2023
752cf9c
Add GUIDs to new entity types
db-robot Apr 18, 2023
df3284e
updated fixes
josephedwardchang Apr 18, 2023
4093d4c
small updates for PR 794
josephedwardchang Apr 25, 2023
8a6d8fb
fix for recent update
josephedwardchang Apr 25, 2023
900fa5a
Merge branch 'master' into master
josephedwardchang Apr 25, 2023
ccbd2c6
fix for update PR 794
josephedwardchang Apr 25, 2023
fa67e61
Add GUIDs to new entity types
db-robot Apr 25, 2023
8b27de1
Merge branch 'master' into master
josephedwardchang May 8, 2023
dabf5cf
Merge branch 'master' into master
josephedwardchang May 17, 2023
eec6adf
Merge branch 'master' into master
josephedwardchang May 23, 2023
4419fd8
Merge branch 'master' into master
josephedwardchang Jun 13, 2023
7f95422
Merge branch 'master' into master
josephedwardchang Jun 19, 2023
c40a34e
removed HVAC/VLV_MWCM, cleaned guids
josephedwardchang Jun 19, 2023
594b1bd
Add GUIDs to new entity types
db-robot Jun 19, 2023
452bc49
Merge branch 'master' into master
cstirdivant Jun 19, 2023
7fdf7bb
Merge branch 'master' into master
josephedwardchang Jun 22, 2023
ee0ffa9
updated based on new feedback from cstridivant
josephedwardchang Jun 22, 2023
fca33e9
Merge branch 'master' into master
josephedwardchang Jun 23, 2023
cef41ff
updated based on new feedback from cstirdivant
josephedwardchang Jun 23, 2023
a6749b2
updated based on new feedback from cstirdivant
josephedwardchang Jun 23, 2023
a47fb6d
Add GUIDs to new entity types
db-robot Jun 23, 2023
8745d67
updated based on comments from cstirdivant
josephedwardchang Jun 30, 2023
9382c73
Merge branch 'master' of https://github.com/josephedwardchang/digital…
josephedwardchang Jun 30, 2023
dd586de
updated based on comments from cstirdivant
josephedwardchang Jun 30, 2023
542733d
Add GUIDs to new entity types
db-robot Jun 30, 2023
10a4c0b
Merge branch 'master' into master
josephedwardchang Jul 3, 2023
8f9724d
Add GUIDs to new entity types
db-robot Jul 3, 2023
53ecea6
updated fixes based on comments from cstirdivant
josephedwardchang Jul 3, 2023
86ca682
Merge branch 'master' into master
cstirdivant Jul 5, 2023
8c65ded
Add GUIDs to new entity types
db-robot Jul 5, 2023
6ec4f40
Merge branch 'master' into master
josephedwardchang Jul 6, 2023
ee70bb7
updated based on new feedbacks
josephedwardchang Jul 6, 2023
ace05ad
Merge branch 'master' into master
josephedwardchang Jul 11, 2023
b0cb7f2
updated based on new feedback
josephedwardchang Jul 13, 2023
1719259
moved dampers_ from FD_SD to FD_STD opt_uses:damper_command
josephedwardchang Jul 15, 2023
32ac6b8
updated: diff pressure sensor and FAN_SS (added opt_uses: air_pressur…
josephedwardchang Jul 18, 2023
ded801f
Add GUIDs to new entity types
db-robot Jul 18, 2023
fd6f343
Merge branch 'master' into master
josephedwardchang Jul 19, 2023
5609518
Merge branch 'master' into master
josephedwardchang Jul 20, 2023
f33e281
Merge branch 'master' into master
josephedwardchang Jul 21, 2023
42e7b3e
Merge branch 'master' into master
josephedwardchang Jul 25, 2023
71d21c8
minor removals/fixes based on new feedbacks
josephedwardchang Jul 25, 2023
99350fc
Merge branch 'master' into master
josephedwardchang Jul 27, 2023
799d7a2
Merge branch 'master' into master
josephedwardchang Jul 28, 2023
7add5c5
Merge branch 'master' into master
josephedwardchang Jul 31, 2023
98fdaac
fix to remove air_pressure_sensor in FAN_SS
josephedwardchang Aug 14, 2023
5f49c9a
Merge branch 'master' into master
josephedwardchang Aug 15, 2023
7870166
fix telemetry_fields
josephedwardchang Aug 15, 2023
9cf80c6
Merge branch 'master' into master
josephedwardchang Aug 17, 2023
2b4d3ae
Merge branch 'master' into master
josephedwardchang Aug 22, 2023
1567954
Merge branch 'master' into master
josephedwardchang Aug 23, 2023
d44238c
updated based on new feedbacks from DBO team
josephedwardchang Aug 24, 2023
769e32b
Merge branch 'master' of https://github.com/josephedwardchang/digital…
josephedwardchang Aug 24, 2023
659c76f
update minor fix
josephedwardchang Aug 24, 2023
32e6327
Merge branch 'master' into master
josephedwardchang Aug 29, 2023
484d6cd
Merge branch 'master' into master
josephedwardchang Sep 4, 2023
2a48c9e
Merge branch 'master' into master
josephedwardchang Sep 8, 2023
d0cc749
Merge branch 'master' into master
josephedwardchang Sep 14, 2023
93e0fca
Merge branch 'master' into master
josephedwardchang Sep 18, 2023
b884673
Merge branch 'master' into master
josephedwardchang Sep 20, 2023
36e38cc
Merge branch 'master' into master
josephedwardchang Sep 21, 2023
d4fcc25
Merge branch 'master' into master
josephedwardchang Sep 29, 2023
2c7d332
Add GUIDs to new entity types
db-robot Sep 29, 2023
afba10f
Merge branch 'master' into master
cstirdivant Oct 2, 2023
4b31179
Merge branch 'master' into master
cstirdivant Oct 2, 2023
7eab65c
renamed points for better description
josephedwardchang Oct 3, 2023
eab0edd
Merge branch 'master' into master
josephedwardchang Oct 4, 2023
4858175
Merge branch 'master' into master
cstirdivant Oct 4, 2023
21e1343
Add GUIDs to new entity types
db-robot Oct 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,10 @@ GEN:
ATS:
guid: "f2e50348-ce8d-4c2e-9e82-0d6056d4c89c"
description: "Tag for automatic transfer switch (ATS) units."

is_abstract: true
implements:
- EQUIPMENT





CB:
guid: "245e084f-a577-441d-a88e-662fd8396271"
description: "Tag for all circuit breakers."
Expand Down
5 changes: 0 additions & 5 deletions ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ RDM:
implements:
- MONITORING


DD:
guid: "5b09f1bd-f526-4d77-b1a3-1fceda2ba041"
description: "Dual duct flow control (hot deck, cold deck)."
Expand Down Expand Up @@ -4470,7 +4469,6 @@ WDPM:
- high_differential_pressure_alarm
- low_differential_pressure_alarm


CHWDPM:
guid: "dcdb66fc-576b-4475-a1cd-f143e16edcde"
description: "Differential pressure monitoring for chilled water."
Expand Down Expand Up @@ -4558,7 +4556,6 @@ CHDXVSC:
- failed_compressor_alarm
- overload_compressor_alarm


CDWFRM:
guid: "b4cd6a63-df02-4c7b-bf81-3902cd827241"
description: "Condenser water flowrate monitoring."
Expand Down Expand Up @@ -6442,7 +6439,6 @@ SWCM:
- valve_command
- valve_status


SCRSS:
guid: "636b1262-b08b-4e1b-b130-e1a510b79a0c"
description: "Scurbber start stop monitoring."
Expand Down Expand Up @@ -6540,7 +6536,6 @@ CO2M6X:
implements:
- MONITORING


MIPCVM:
guid: "17630266-40d3-4bc5-a9cd-9d70f10ef839"
description: "Motor phase-level input current and voltage monitoring."
Expand Down
1 change: 0 additions & 1 deletion ontology/yaml/resources/HVAC/entity_types/DMP.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ DMP_EDBPC_ZTM:
- EDBPC
- ZTM


###################################
### Existing Non-standard Types ###
###################################
Expand Down
3 changes: 1 addition & 2 deletions ontology/yaml/resources/HVAC/entity_types/FAN.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ FAN_SS:
implements:
- FAN
- SS
opt_uses:
- air_pressure_sensor

FAN_SS_VSC:
guid: "b58b9431-ff2c-4cc2-adab-a8c51c4ee6ab"
Expand Down Expand Up @@ -786,3 +784,4 @@ FAN_VSMC:
implements:
- FAN
- VSMC

34 changes: 32 additions & 2 deletions ontology/yaml/resources/HVAC/entity_types/FCU.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1200,7 +1200,7 @@ FCU_DFSS_DXRC_RHDHC_AL:
- filter_alarm
- master_alarm
- failed_heat_exchange_alarm
- water_leak_alarm
- water_leak_alarm

FCU_DFVSC_CHWRC_FDPSM2X:
guid: "26ec8491-3ccd-42f6-86e7-9d69afeb87bd"
Expand Down Expand Up @@ -1442,7 +1442,7 @@ FCU_NONCANONICAL_1:
- zone_occupancy_status_1
- zone_occupancy_status_2
- zone_occupancy_status_3

FCU_DFSS_CSP_ZHC_DXZC_NONCANONICAL_1:
guid: "0bca6899-fa9a-40ff-a3bd-8828991b39c1"
description: "Non-standard type."
Expand Down Expand Up @@ -1761,3 +1761,33 @@ FCU_DFVSC_RTM_CO2M_HWZTC_CHWZTC:
- CO2M
- HWZTC
- CHWZTC


FCU_DXZTC_DFSS:
guid: "5688519e-f88e-4620-8bd5-89d91467028d"
description: "FCU with SS, discharge temp sensors, zone control and sensor, filter change"
is_canonical: true
implements:
- FCU
- DXZTC
- DFSS
opt_uses:
- failed_alarm
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
- filter_alarm

FCU_RHDHS_DXDC_DFSS_RTM:
guid: "f60a2563-da8f-4360-b2d9-f471c065356c"
description: "FCU with temperature & pressure monitor, humidity monitor and water leak & status alarm."
is_canonical: true
implements:
tasodorff marked this conversation as resolved.
Show resolved Hide resolved
- FCU
- RHDHS
- DXDC
- DFSS
- RTM
opt_uses:
- water_leak_alarm
- failed_alarm
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
- high_discharge_air_static_pressure_alarm
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
- low_discharge_air_static_pressure_alarm
- low_discharge_air_flowrate_alarm
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions ontology/yaml/resources/HVAC/entity_types/MAU.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -841,3 +841,4 @@ MAU_SFSS_SFVSC_HTSC_BPC_SHM_NONCANONICAL_2:
- DEPRECATED
uses:
- humidification_run_command

2 changes: 1 addition & 1 deletion ontology/yaml/resources/HVAC/entity_types/SENSOR.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ SENSOR_ZA_CO2M_PMM_HCHO:
- CO2M
- PMM
uses:
- zone_air_formaldehyde_concentration_sensor
- zone_air_formaldehyde_concentration_sensor

SENSOR_CO2M_VOCM:
guid: "3eca4fc4-0a66-4a12-bbc1-88fedeb9ede5"
Expand Down
1 change: 0 additions & 1 deletion ontology/yaml/resources/METERS/entity_types/WM.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,3 @@ WM_WF:
opt_uses:
- supply_water_volume_accumulator
- water_linearvelocity_sensor
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
- water_volume_accumulator
7 changes: 7 additions & 0 deletions ontology/yaml/resources/PLUMBING/entity_types/ABSTRACT.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,11 @@ LVLM:
- level_status
opt_uses:
- percentage_sensor

WVCM:
description: "Water valve control and monitoring."
is_abstract: true
uses:
- valve_command
- valve_status

17 changes: 16 additions & 1 deletion ontology/yaml/resources/PLUMBING/entity_types/GENERALTYPES.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,19 @@ RO:
is_abstract: true
implements:
- EQUIPMENT


VLV:
guid: "396ab9cc-500d-4e0a-b09c-be249cb3e420"
description: "Tag for valves. Valves are devices which control the flow of water. "
is_abstract: true
opt_uses:
- failed_communication_alarm
implements:
- EQUIPMENT

WSR:
guid: "178274c8-ec3d-4c5a-b2f3-f5ae7cb894dc"
description: "Water softener"
is_abstract: true
implements:
- EQUIPMENT
25 changes: 25 additions & 0 deletions ontology/yaml/resources/PLUMBING/entity_types/VLV.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Copyright 2023 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the License);
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an AS IS BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

########################
### Canonical Types ###
########################

VLV_WVCM:
guid: "63e9ccb7-67f6-4547-aff8-d3cf30d1ab40"
description: "Solenoid water valve control and monitoring."
is_canonical: true
implements:
- VLV
- WVCM
27 changes: 27 additions & 0 deletions ontology/yaml/resources/PLUMBING/entity_types/WSR.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Copyright 2022 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the License);
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an AS IS BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

### CANONICAL TYPES

WSR_STD:
guid: "c406cac4-2e0c-4396-8963-db72b7f1ccb6"
description: "Standard water softener."
is_canonical: true
implements:
- WSR
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
- /SS
uses:
- water_flowrate_status
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
opt_uses:
- lost_power_alarm
14 changes: 12 additions & 2 deletions ontology/yaml/resources/SAFETY/entity_types/ABSTRACT.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ H2M:
is_abstract: true
uses:
- zone_air_h2_concentration_sensor
opt_uses:
- high_zone_air_h2_concentration_alarm

WLDS:
guid: "6530f835-51a6-45c0-9130-382c297c2a01"
Expand Down Expand Up @@ -86,11 +88,19 @@ WLS:
is_abstract: true
uses:
- water_leak_cable_distance_sensor

LM:
guid: "25887ceb-f2d8-4b25-be80-36e8b37f5ae9"
description: "Tank level monitoring."
is_abstract: true
uses:
- level_status
- level_status

ASD:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the system have different responses at each level of alarm (in other words, is the system response for a low_smoke_alarm different from the response to a high_smoke_alarm?)

Copy link
Contributor Author

@josephedwardchang josephedwardchang Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, ma'am. for low smoke BMS has a warning alert on PC. (There is no high smoke this is equivalent to fire alarm) for fire alarm, siren is on. For medium smoke, not sure, I'll ask the BMS team for that, will report back on this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that makes sense. I Notice here this type only has opt_uses (which is not best-practice). In this case, I suggest deleting the ASD type completely and simply defining these fields on the FACP_ASD type directly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted ma'am, removed ASD now.

guid: "d5829c05-fc88-4ac4-8587-8c75ed0d0486"
description: "Aspirating type, smoke detector."
is_abstract: true
opt_uses:
- low_smoke_alarm
- medium_smoke_alarm
- fire_alarm
26 changes: 26 additions & 0 deletions ontology/yaml/resources/SAFETY/entity_types/EHT.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Copyright 2022 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the License);
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an AS IS BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

########################
### Canonical Types ###
########################


EHT_SS:
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
guid: "fd135e80-a15b-4c3f-8fa8-31c0641933a3"
description: "Basic heat tracer with start/stop"
is_canonical: true
implements:
- EHT
- SS
14 changes: 14 additions & 0 deletions ontology/yaml/resources/SAFETY/entity_types/FACP.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ FACP_STD:
- FACP
uses:
- fire_alarm
opt_uses:
- failed_panel_alarm

FACP_FA2X:
guid: "a29a1bdd-0f8c-498e-b4ed-d09789f2487c"
Expand All @@ -45,3 +47,15 @@ FACP_PAS:
- supervisor_alarm
- water_flowrate_status
- air_pressure_status
opt_uses:
- failed_panel_alarm

FACP_ASD:
guid: "3f21bbad-15ad-4253-982d-fed1324543d3"
description: "Basic aspirating type, fire detection with alarms."
is_canonical: true
implements:
- FACP
- ASD
opt_uses:
- failed_panel_alarm
3 changes: 2 additions & 1 deletion ontology/yaml/resources/SAFETY/entity_types/FD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ FD_STD:
- FD
uses:
- damper_status
opt_uses:
- damper_command

FD_SD:
guid: "70dad00c-3334-4a77-8ce2-2d41d6a97c78"
Expand All @@ -31,4 +33,3 @@ FD_SD:
uses:
- damper_percentage_sensor
- damper_percentage_command

11 changes: 11 additions & 0 deletions ontology/yaml/resources/SAFETY/entity_types/FSS.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,14 @@ FSS_STD:
- FSS
uses:
- fire_alarm

FSS_FA2X_GS:
guid: "637223a2-1c85-4ba3-b28f-ba5c96ffce9d"
description: "Fire Suppression System with with 2-level alarm and gas suppression."
is_canonical: true
implements:
- FSS
- FA2X
uses:
- failed_panel_alarm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This panel alarm probably belongs on an FACP type instead. Everything else on this type is reasonable, though.

Copy link
Contributor Author

@josephedwardchang josephedwardchang Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would need help to rename this point because it is a general alarm, a catch-all alarm if there is something wrong other than fire or power fail. the description for this was supervisor alarm, in which when it's on a supervisor for the device could check things out. my few suggestions could be:

  • event_alarm
  • maintenance_alarm
  • master_alarm
  • process_alarm
  • supervisor_alarm

these are not in subfields yet:

  • general_alarm
  • device_alarm

any more suggestions ma'am?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using master_alarm to model this catch-all alarm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted ma'am. Replaced failed panel alarm to master alarm now

- gas_release_status
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,17 @@ SSS:
is_abstract: true
implements:
- /SENSOR

HDS:
guid: "025f5773-7626-4a30-bd44-ef0845a92215"
description: "Hydrogen Sensor."
is_abstract: true
implements:
- /SENSOR

cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
EHT:
guid: "700c69bb-8d37-4e5f-806f-ae64d007cf35"
description: "Tag for a heat tracer. A heat tracer is typically a heated coil that is wound around pipes to prevent the liquid inside from freezing."
is_abstract: true
implements:
- EQUIPMENT
3 changes: 1 addition & 2 deletions ontology/yaml/resources/SAFETY/entity_types/HDS.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2020 Google LLC
# Copyright 2023 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the License);
# you may not use this file except in compliance with the License.
Expand All @@ -24,4 +24,3 @@ HDS_H2M:
implements:
- HDS
- H2M

2 changes: 1 addition & 1 deletion ontology/yaml/resources/entity_types/global.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ INCOMPLETE:
guid: "bfc45ea7-8695-4013-bc0a-6ec0732cce6d"
description: "A known incomplete type."
is_abstract: true

##Global namespace for tanks##
TK:
guid: "ada23c08-00af-4967-8148-33239e8564f7"
Expand Down
Loading