-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New devices HDS, WSR, etc #794
Changes from 82 commits
5c86108
a818cfc
e7586b7
9d98f73
f533bbe
f011703
589ae2a
96765e1
cc03351
621a570
d38bfe5
12ccc03
5eb1202
4c1f65f
18acfee
854bdce
3eae6ef
76b63b5
a7d2b73
dacebaf
63beea3
38c2837
0e12995
5e58c4d
cf20284
072f958
cd0971c
8cec630
3614d43
ed3c2ac
e3e92bc
83ba6d5
30156b2
eb234d3
7487046
b54beb1
7121a03
3947b94
e6fac0a
75b52eb
8b8811b
68c239e
8396828
96769ed
e41cd00
1262370
247ce3c
2e01e81
4529e45
752cf9c
df3284e
4093d4c
8a6d8fb
900fa5a
ccbd2c6
fa67e61
8b27de1
dabf5cf
eec6adf
4419fd8
7f95422
c40a34e
594b1bd
452bc49
7fdf7bb
ee0ffa9
fca33e9
cef41ff
a6749b2
a47fb6d
8745d67
9382c73
dd586de
542733d
10a4c0b
8f9724d
53ecea6
86ca682
8c65ded
6ec4f40
ee70bb7
ace05ad
b0cb7f2
1719259
32ac6b8
ded801f
fd6f343
5609518
f33e281
42e7b3e
71d21c8
99350fc
799d7a2
7add5c5
98fdaac
5f49c9a
7870166
9cf80c6
2b4d3ae
1567954
d44238c
769e32b
659c76f
32e6327
484d6cd
2a48c9e
d0cc749
93e0fca
b884673
36e38cc
d4fcc25
2c7d332
afba10f
4b31179
7eab65c
eab0edd
4858175
21e1343
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,6 +66,15 @@ UPS_IOBM_PPWM_UPSBM: | |
- IOBM | ||
- PPWM | ||
- UPSBM | ||
|
||
UPS_SS_BBM: | ||
guid: "adcf545f-eb61-4130-a0f1-d611ab303d17" | ||
description: "UPS unit with load bypass and battery mode and alarm." | ||
is_canonical: true | ||
implements: | ||
- UPS | ||
- SS | ||
- BBM | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The functionality you are trying to model with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. noted ma'am, will remove this. usually it is only alarms that get affected. |
||
|
||
UPS_PWM: | ||
guid: "64f90598-969d-4cf6-ace6-50793a46aed8" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1188,7 +1188,7 @@ FCU_DFSS_DXRC_RHDHC_AL: | |
- filter_alarm | ||
- master_alarm | ||
- failed_heat_exchange_alarm | ||
- water_leak_alarm | ||
- water_leak_alarm | ||
|
||
FCU_DFVSC_CHWRC_FDPSM2X: | ||
guid: "26ec8491-3ccd-42f6-86e7-9d69afeb87bd" | ||
|
@@ -1699,3 +1699,34 @@ FCU_DSP_DFVSC_DTM_RTM: | |
- DTM | ||
- RTM | ||
|
||
|
||
FCU_DXZTC_DFSS: | ||
guid: "5688519e-f88e-4620-8bd5-89d91467028d" | ||
description: "FCU with SS, discharge temp sensors, zone control and sensor, filter change" | ||
is_canonical: true | ||
implements: | ||
- FCU | ||
- DXZTC | ||
- DFSS | ||
opt_uses: | ||
- failed_alarm | ||
cstirdivant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- filter_alarm | ||
|
||
FCU_RHDHS_DXDC_DFSS_RTM: | ||
guid: "f60a2563-da8f-4360-b2d9-f471c065356c" | ||
description: "FCU with temperature & pressure monitor, humidity monitor and water leak & status alarm." | ||
is_canonical: true | ||
implements: | ||
tasodorff marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- FCU | ||
- RHDHS | ||
- DXDC | ||
- DFSS | ||
- RTM | ||
uses: | ||
cstirdivant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- run_status | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How is this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. run_status checks if the whole unit is on/off. as I didn't see this point anywhere, should it be in opt_uses section? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is unnecessary to include as we typically can infer if the unit is running based on the |
||
opt_uses: | ||
- water_leak_alarm | ||
- failed_alarm | ||
cstirdivant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- high_discharge_air_static_pressure_alarm | ||
cstirdivant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- low_discharge_air_static_pressure_alarm | ||
- low_discharge_air_flowrate_alarm | ||
cstirdivant marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -841,3 +841,4 @@ MAU_SFSS_SFVSC_HTSC_BPC_SHM_NONCANONICAL_2: | |
- DEPRECATED | ||
uses: | ||
- humidification_run_command | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -233,7 +233,15 @@ SENSOR_ZA_CO2M_PMM_HCHO: | |
- CO2M | ||
- PMM | ||
uses: | ||
- zone_air_formaldehyde_concentration_sensor | ||
- zone_air_formaldehyde_concentration_sensor | ||
|
||
SENSOR_WDPM: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if these are used for non-hvac purposes, Id move to a more appropriate namespace (e.g. if they are used for fire systems, move to SAFETY). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. noted sir. will add this to SAFETY if it's used there There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. has this been updated? still seeing them here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for HVAC sir. we're checking if this is also used for water pressure monitoring,for that I'll basically do a copy under PLUMBING, yes? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SENSOR_WDPM is only used for HVAC, so this stays sir. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No ma'am, this is stand-alone pressure sensor. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is this sensor located? It seems odd to have a standalone sensor that is not reading the differential pressure as part of a larger system control (for example, pumps probably control their speed based on the measured pressure from this sensor). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @josephedwardchang you've noted that this sensor is used to prove if the kitchen exhaust fans are on. Therefore, this belongs as part of the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i see, noted on this, ma'am. will do. But do I need to remove SENSOR_WDPM then? I will use WDPM as it is a diff pressure sensor and not a static one. Had talked with BMS again, with correction: it is in Supply Fan that DPS was connected (not exhaust fan, sorry). I'll make Supply fan changes to include WDPM. The same goes with our FCU to add air_pressure_sensor as BMS team also said FCU has pressure sensor as its part (similar on/off status with supply fans). They said because the building landlord doesn't provide direct control/status. Thanks There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes please remove this sensor type. You no longer need it if you are modeling the pressure fields on each equipment type (FAN and FCU). |
||
guid: "c0eb13ea-8495-46de-8443-9a3b5696d084" | ||
description: "Sensor with differential pressure monitor" | ||
is_canonical: true | ||
implements: | ||
- /SENSOR | ||
- WDPM | ||
|
||
SENSOR_CO2M_VOCM: | ||
guid: "3eca4fc4-0a66-4a12-bbc1-88fedeb9ede5" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,4 +40,20 @@ RO: | |
is_abstract: true | ||
implements: | ||
- EQUIPMENT | ||
|
||
|
||
VLV: | ||
guid: "396ab9cc-500d-4e0a-b09c-be249cb3e420" | ||
description: "Tag for valves. Valves are devices which control the flow of water. " | ||
is_abstract: true | ||
opt_uses: | ||
- failed_communication_alarm | ||
implements: | ||
- EQUIPMENT | ||
|
||
WSR: | ||
guid: "178274c8-ec3d-4c5a-b2f3-f5ae7cb894dc" | ||
description: "Water softener" | ||
is_abstract: true | ||
implements: | ||
- /SS | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove from here and add to the type in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. noted on above as well. Thanks ma'am |
||
- EQUIPMENT |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the License); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an AS IS BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
######################## | ||
### Canonical Types ### | ||
######################## | ||
|
||
VLV_WVCM: | ||
guid: "63e9ccb7-67f6-4547-aff8-d3cf30d1ab40" | ||
description: "Solenoid water valve control and monitoring." | ||
is_canonical: true | ||
implements: | ||
- VLV | ||
- WVCM |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# Copyright 2022 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the License); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an AS IS BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
### CANONICAL TYPES | ||
|
||
WSR_STD: | ||
guid: "c406cac4-2e0c-4396-8963-db72b7f1ccb6" | ||
description: "Standard water softener." | ||
is_canonical: true | ||
implements: | ||
- WSR | ||
cstirdivant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
uses: | ||
- water_flowrate_status | ||
cstirdivant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
opt_uses: | ||
- lost_power_alarm |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,8 @@ H2M: | |
is_abstract: true | ||
uses: | ||
- zone_air_h2_concentration_sensor | ||
opt_uses: | ||
- high_zone_air_h2_concentration_alarm | ||
|
||
WLDS: | ||
guid: "6530f835-51a6-45c0-9130-382c297c2a01" | ||
|
@@ -86,11 +88,27 @@ WLS: | |
is_abstract: true | ||
uses: | ||
- water_leak_cable_distance_sensor | ||
|
||
LM: | ||
guid: "25887ceb-f2d8-4b25-be80-36e8b37f5ae9" | ||
description: "Tank level monitoring." | ||
is_abstract: true | ||
uses: | ||
- level_status | ||
- level_status | ||
|
||
MDC: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove this type (see comment on FD file) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noted ma'am. Thanks |
||
guid: "ec1aab74-c961-40fd-87b7-ce219c9c6d3a" | ||
description: "Motorized binary damper control." | ||
is_abstract: true | ||
uses: | ||
- damper_status | ||
- damper_command | ||
|
||
ASD: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the system have different responses at each level of alarm (in other words, is the system response for a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, ma'am. for low smoke BMS has a warning alert on PC. (There is no high smoke this is equivalent to fire alarm) for fire alarm, siren is on. For medium smoke, not sure, I'll ask the BMS team for that, will report back on this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok that makes sense. I Notice here this type only has opt_uses (which is not best-practice). In this case, I suggest deleting the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noted ma'am, removed ASD now. |
||
guid: "d5829c05-fc88-4ac4-8587-8c75ed0d0486" | ||
description: "Aspirating type, smoke detector." | ||
is_abstract: true | ||
opt_uses: | ||
- low_smoke_alarm | ||
- medium_smoke_alarm | ||
- fire_alarm |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# Copyright 2022 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the License); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an AS IS BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
######################## | ||
### Canonical Types ### | ||
######################## | ||
|
||
|
||
EHT_SS: | ||
cstirdivant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
guid: "fd135e80-a15b-4c3f-8fa8-31c0641933a3" | ||
description: "Basic heat tracer with start/stop" | ||
is_canonical: true | ||
implements: | ||
- EHT | ||
- SS |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,4 +31,11 @@ FD_SD: | |
uses: | ||
- damper_percentage_sensor | ||
- damper_percentage_command | ||
|
||
|
||
FD_MDC: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It probably makes more sense to add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see, I can do that. Thanks ma'am There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You added this to the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh sorry, my mistake. now corrected. |
||
guid: "a731be05-13de-43a5-9edc-9fd89c6cfffc" | ||
description: "Fire dampers with motorized binary dampers (open/closed)" | ||
is_canonical: true | ||
implements: | ||
- FD | ||
- MDC |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,3 +23,14 @@ FSS_STD: | |
- FSS | ||
uses: | ||
- fire_alarm | ||
|
||
FSS_FA2X_GS: | ||
guid: "637223a2-1c85-4ba3-b28f-ba5c96ffce9d" | ||
description: "Fire Suppression System with with 2-level alarm and gas suppression." | ||
is_canonical: true | ||
implements: | ||
- FSS | ||
- FA2X | ||
uses: | ||
- failed_panel_alarm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This panel alarm probably belongs on an FACP type instead. Everything else on this type is reasonable, though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would need help to rename this point because it is a general alarm, a catch-all alarm if there is something wrong other than fire or power fail. the description for this was supervisor alarm, in which when it's on a supervisor for the device could check things out. my few suggestions could be:
these are not in subfields yet:
any more suggestions ma'am? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noted ma'am. Replaced failed panel alarm to master alarm now |
||
- gas_release_status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this type (see comment on UPS.yaml)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note ma'am, will do. thanks