Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add feedback_* to i18n/ja.toml #2149

Merged
merged 1 commit into from
Jan 4, 2025
Merged

i18n: Add feedback_* to i18n/ja.toml #2149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions i18n/ja.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,13 @@ other = "If you want to get more involved by contributing to {{ .Site.Title }},
other = "You can find out how to contribute to {{ .Site.Title }} in our"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that there are some more untranslated lines/strings in this file:

https://github.com/google/docsy/blob/fa81a86be8bf130d94a43b8898c6716819fdae87/i18n/ja.toml#L63C1-L79C34

@rinsuki: are you able to translate these lines as well? Your help is appreciated!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically I can directly translate word-by-word, but I think it wouldn't be a good translate (If I do that, japanese speakers (like me) feels it is translated from other language rather than written by native), but I don't have a idea to good paraphrase for its text right now.

by the way, community_how_to assume text ends with community_guideline:

docsy/layouts/partials/community_links.html

Lines 18 to 21 in fa81a86

<p>
{{ T "community_how_to" . }}
<a href="{{ $contribUrl | relURL }}">{{ T "community_guideline" }}</a>.
</p>

but some languages wants to have additional text after link, it would be good to have something like community_how_to_suffix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks @rinsuki. I'll merge this as an increment, and we can address the other fields as necessary. Thanks for pointing that out @deining.

[community_guideline]
other = "Contribution Guidelines"

# Feedback
[feedback_title]
other = "フィードバック"
[feedback_question]
other = "このページは役に立ちましたか?"
[feedback_positive]
other = "役に立った"
[feedback_negative]
other = "役に立たなかった"
Loading