Skip to content

Fix generating draco project files from a directory containing special characters #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whiteh0le wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

Fix generating draco project files from a directory containing special characters #1140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions cmake/draco_install.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,15 @@ macro(draco_setup_install_target)

foreach(file ${draco_sources})
if(file MATCHES "h$")
list(APPEND draco_api_includes ${file})
# Strip $draco_src_root from the file paths: we need to install relative to
# $include_directory.
file(RELATIVE_PATH relative_file ${draco_src_root} ${file})
list(APPEND draco_api_includes ${relative_file})
endif()
endforeach()

list(REMOVE_DUPLICATES draco_api_includes)

# Strip $draco_src_root from the file paths: we need to install relative to
# $include_directory.
list(TRANSFORM draco_api_includes REPLACE "${draco_src_root}/" "")

foreach(draco_api_include ${draco_api_includes})
get_filename_component(file_directory ${draco_api_include} DIRECTORY)
set(target_directory "${includes_path}/draco/${file_directory}")
Expand Down