Skip to content

Set QoS to USER_INTERACTIVE for socket queues #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set QoS to USER_INTERACTIVE for socket queues #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Channel/Sources/EDOSocket.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ + (void)connectWithTCPPort:(UInt16)port
queue:(dispatch_queue_t)queue
connectedBlock:(EDOSocketConnectedBlock)block {
block = block ?: gNoOpHandlerBlock;
queue = queue ?: dispatch_queue_create("com.google.edo.connectSocket", DISPATCH_QUEUE_SERIAL);
dispatch_queue_attr_t queueAttributes = dispatch_queue_attr_make_with_qos_class( DISPATCH_QUEUE_SERIAL, QOS_CLASS_USER_INTERACTIVE, 0);
queue = queue ?: dispatch_queue_create("com.google.edo.connectSocket", queueAttributes);

int socketErr = 0;
dispatch_fd_t socketFD = edo_CreateSocket(&socketErr);
Expand Down
3 changes: 2 additions & 1 deletion Channel/Sources/EDOSocketChannel.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ - (instancetype)init {
if (self) {
// For internal IO and event handlers, it is equivalent to creating it as a serial queue as they
// are not reentrant and only one block will be scheduled by dispatch io and dispatch source.
dispatch_queue_attr_t queueAttributes = dispatch_queue_attr_make_with_qos_class( DISPATCH_QUEUE_SERIAL, QOS_CLASS_USER_INTERACTIVE, 0);
_handlerQueue =
dispatch_queue_create("com.google.edo.socketChannel.handler", DISPATCH_QUEUE_SERIAL);
dispatch_queue_create("com.google.edo.socketChannel.handler", queueAttributes);
}
return self;
}
Expand Down