[rewrite] Add Java8toJava11
#5328
Conversation
| } | ||
|
|
||
| private static @Nullable Tree suppressibleNode(TreePath path, VisitorState state) { | ||
| return StreamSupport.stream(path.spliterator(), false) |
There was a problem hiding this comment.
There was a problem hiding this comment.
If there is interest in using (a subset of) our Refaster rules, IMO it'd make more sense to directly import them from Error Prone Support, instead of going via OpenRewrite.
CC: @Stephan202
| </dependency> | ||
| <dependency> | ||
| <groupId>jakarta.inject</groupId> | ||
| <artifactId>jakarta.inject-api</artifactId> |
cushon
left a comment
cushon
left a comment
There was a problem hiding this comment.
Were all of the changes in this PR generated by openrewrite using the rewrite.yml config you added?
Some of them look unrelated, like the formatting changes to the pom.xml files and some of the Java files.
|
yes sorry its all related to some individual recipe. Im going to supplement and extract to make it transparent and mergeable. Thank you. |
rewrite.yml
Outdated
| displayName: Apply Java & Maven best practices | ||
| description: Comprehensive code quality recipe combining modernization, security, and best practices. | ||
| recipeList: | ||
| - org.openrewrite.java.RemoveUnusedImports |
There was a problem hiding this comment.
There already exists an Error Prone check for this.
There was a problem hiding this comment.
yes, also all tools have bugs and or different perspectives, never say never.
rewrite.yml
Outdated
| recipeList: | ||
| - org.openrewrite.java.RemoveUnusedImports | ||
| - org.openrewrite.java.format.NormalizeLineBreaks | ||
| - org.openrewrite.java.format.RemoveTrailingWhitespace |
There was a problem hiding this comment.
Would say this cannot occur given the use of Google Java Format.
There was a problem hiding this comment.
yes, also all tools have bugs and or different perspectives, never say never.
spot uses google or palant which is google. (zero trust principle)
Pankraz76
force-pushed
the
pr-rewrite
branch
from
d69eb5f to
8749941
Compare
Pankraz76
changed the title
Java8toJava11Java8toJava11
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
pr-rewrite
branch
from
8749941 to
86da496
Compare
always helpful and welcome. Let me know if something to adjust, kind regards. |
3 participants
related to:
UpgradeToJava17diffplug/spotless#2636Rewrite:UpgradeToJava17checkstyle/checkstyle#17730rewritesupport forerrorprone.refasterrules#5195