Implement config reloading #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/667959949
branch
from
8142134
to
710269a
Compare
copybara-service
bot
force-pushed
the
cl/667959949
branch
5 times, most recently
from
6247954
to
cc86b9c
Compare
The approach here is to pass a channel to InnerMain functions that can be watched for incoming `syscall.SIGHUP` signals. To trigger a config reload, run - `service fleetspeak-client reload` on linux - `launchctl kill SIGHUP system/com.google.code.fleetspeak` on mac - `sc.exe control FleetspeakService paramchange` on windows The default implementation provided simply stops the client and creates another one when a signal is received. PiperOrigin-RevId: 671281569
copybara-service
bot
force-pushed
the
cl/667959949
branch
from
cc86b9c
to
77bf103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement config reloading
The approach here is to pass a channel to InnerMain functions that can be watched for incoming
syscall.SIGHUPsignals.To trigger a config reload, run
service fleetspeak-client reloadon linuxlaunchctl kill SIGHUP system/com.google.code.fleetspeakon macsc.exe control FleetspeakService paramchangeon windowsThe default implementation provided simply stops the client and creates another one when a signal is received.