Skip to content

Bump clang-format version to v19 #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boomanaiden154 merged 1 commit into from
Jan 29, 2025
Merged

Bump clang-format version to v19 #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Check c++ formatting
uses: jidicula/clang-format-action@v4.11.0
uses: jidicula/clang-format-action@v4.14.0
with:
clang-format-version: '18'
clang-format-version: '19'
check-path: 'src'
check-bazel-formatting:
name: Bazel Formatting Check
Expand Down
2 changes: 1 addition & 1 deletion gematria/basic_block/basic_block.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ std::ostream& operator<<(std::ostream& os, const InstructionOperand& operand);
// Represents an annotation holding a value such as some measure/statistic
// paired with the instruction.
struct Annotation {
Annotation() : value(-1){};
Annotation() : value(-1) {};

// Initializes all fields of the annotation.
Annotation(std::string name, double value);
Expand Down
2 changes: 1 addition & 1 deletion gematria/datasets/exegesis_benchmark_lib_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class ExegesisBenchmarkTest : public testing::Test {
std::unique_ptr<ExegesisBenchmark> Benchmark;

protected:
ExegesisBenchmarkTest() : Benchmark(cantFail(ExegesisBenchmark::create())){};
ExegesisBenchmarkTest() : Benchmark(cantFail(ExegesisBenchmark::create())) {};

static void SetUpTestSuite() {
// LLVM Setup
Expand Down
2 changes: 1 addition & 1 deletion gematria/datasets/process_and_filter_bbs_lib_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class ProcessFilterBBsTest : public testing::Test {
: LLVMArchSupport(LlvmArchitectureSupport::X86_64()),
LLVMInstPrinter(LLVMArchSupport->CreateMCInstPrinter(
InlineAsm::AsmDialect::AD_ATT)),
BBProcessor(){};
BBProcessor() {};

std::vector<DisassembledInstruction> removeRiskyInstructions(
std::string_view TextualAssembly, bool FilterMemoryAccessingBlocks) {
Expand Down