Add histogram summaries to GnnModelBase.
#314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrasej
requested changes
Apr 17, 2025
virajbshah
force-pushed
the
histogram-summaries
branch
from
5a46a8c to
572fa73
Compare
Collaborator
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
What exactly is the purpose of logging the weight distributions like this?
Contributor
Author
|
It's supposed to be an extra diagnostic to catch things like some weights exploding or gradients vanishing. I added it to compare embedding distributions between regular and context nodes. |
Collaborator
Ah, okay. Definitely makes sense as a diagnostic tool for that. And I guess the size increase isn't large because it's just a histogram over each layer. |
boomanaiden154
approved these changes
Jul 4, 2025
Collaborator
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM, but it's probably good to wait for Ondrej's approval as well.
ondrasej
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GnnModelBaseto log histogram summaries for all of its trainable variables, i.e. those in the graph network layers.