Add "Download GeoJSON" menu option #2138
Conversation
…ta-to-be-exported-as-geojson
| res.status(HttpStatus.FORBIDDEN).send('Permission denied'); | ||
| return; | ||
| } | ||
| const ownerId = canImport(user, surveyDoc) ? undefined : userId; |
There was a problem hiding this comment.
Should this logic be reversed? If canImport is true, the ownerId is the userId? Or is this the correct logic? Maybe a comment would help clarify, if this is right.
| /** | ||
| * Iterates over all LOIsin a job returning a valid GeoJSON file. | ||
| */ | ||
| export async function exportGeojsonHandler( |
There was a problem hiding this comment.
This is quite a long function. This is a nit, but any way this could be split up into useful chunks of logic? e.g. error checking, writing rows, etc.
There was a problem hiding this comment.
There are a fair few things from the function that are not tested here, especially error cases. I understand not testing everything, but anything that's especially important that you think we should test?
There was a problem hiding this comment.
After investigating the export-csv test logic, I found that the jsonstream library uses a queue for writing to the stream and I didn't find a way to capture this.
Maybe we can change the mocking strategy, so instead of mocking the entire response, I'll likely get better results by focusing my tests on the transformation of he LOI data into GeoJSON features.
There was a problem hiding this comment.
wdyt @nwkotto ?
There was a problem hiding this comment.
Yeah, that makes sense, it would be nice to check that the transformation from LOI to GeoJSON is working correctly, instead of the focus on the overall request. But I don't want to hold this up, either, if you've tested this manually -- could split out that functionality and test it in a follow-up PR.
gino-m
changed the title
rfontanarosa
deleted the
rfontanarosa/2013/export-job-data-allow-data-to-be-exported-as-geojson
branch
closes #2013
Registrazione.schermo.2025-02-04.alle.17.14.04.mov