Skip to content

Commit

Permalink
Debug issues w/ default GPU test
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 670750194
  • Loading branch information
zkoopmans authored and gvisor-bot committed Sep 23, 2024
1 parent 48b7308 commit 8a0f7ba
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
7 changes: 7 additions & 0 deletions .buildkite/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,13 @@ steps:
- make cos-gpu-all-tests
agents:
queue: cos-canary-gpu
- <<: *common
<<: *source_test
label: ":male_supervillain: COS GPU Tests (Default)"
commands:
- make cos-gpu-all-tests
agents:
queue: cos-canary-gpu-default
- <<: *common
<<: *source_test_continuous
label: ":screwdriver: All GPU Drivers Test"
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -284,15 +284,15 @@ gpu-smoke-images: load-basic_cuda-vector-add load-gpu_cuda-tests
.PHONY: gpu-smoke-images

gpu-smoke-tests: gpu-smoke-images $(RUNTIME_BIN)
@$(call sudo,test/gpu:smoke_test,--runtime=runc -test.v $(ARGS))
@$(call install_runtime,$(RUNTIME),--nvproxy=true --nvproxy-docker=true)
@$(call sudo,test/gpu:smoke_test,--runtime=$(RUNTIME) -test.v $(ARGS))
@$(call sudo,test/gpu:smoke_test,--runtime=runc -test.v $(ARGS))
.PHONY: gpu-smoke-tests

cos-gpu-smoke-tests: gpu-smoke-images $(RUNTIME_BIN)
@$(call sudo,test/gpu:smoke_test,--runtime=runc -test.v --cos-gpu $(ARGS))
@$(call install_runtime,$(RUNTIME),--nvproxy=true)
@$(call sudo,test/gpu:smoke_test,--runtime=$(RUNTIME) -test.v --cos-gpu $(ARGS))
@$(call sudo,test/gpu:smoke_test,--runtime=runc -test.v --cos-gpu $(ARGS))
.PHONY: cos-gpu-smoke-tests

# Images needed for GPU tests.
Expand Down
7 changes: 4 additions & 3 deletions pkg/test/dockerutil/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,13 @@ func (c *Container) Run(ctx context.Context, r RunOpts, args ...string) (string,

if err := c.Start(ctx); err != nil {
logs, _ := c.Logs(ctx)
return logs, err
return logs, fmt.Errorf("failed to start container: %w", err)
}

if err := c.Wait(ctx); err != nil {
info, ierr := c.client.ContainerInspect(ctx, c.id)
logs, _ := c.Logs(ctx)
return logs, err
return logs, fmt.Errorf("failed to wait for container: %w info: %+v info_err: %v", err, info.ContainerJSONBase.State, ierr)
}

return c.Logs(ctx)
Expand Down Expand Up @@ -288,7 +289,7 @@ func (c *Container) create(ctx context.Context, profileImage string, conf *conta
}
cont, err := c.client.ContainerCreate(ctx, conf, hostconf, nil, nil, c.Name)
if err != nil {
return err
return fmt.Errorf("ContainerCreate failed: %v warnings: %v", err, cont.Warnings)
}
c.id = cont.ID
return nil
Expand Down

0 comments on commit 8a0f7ba

Please sign in to comment.