Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug issues w/ default GPU test #10855

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .buildkite/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,13 @@ steps:
- make cos-gpu-all-tests
agents:
queue: cos-canary-gpu
- <<: *common
<<: *source_test
label: ":male_supervillain: COS GPU Tests (Default)"
commands:
- make cos-gpu-all-tests
agents:
queue: cos-canary-gpu-default
- <<: *common
<<: *source_test_continuous
label: ":screwdriver: All GPU Drivers Test"
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -284,15 +284,15 @@ gpu-smoke-images: load-basic_cuda-vector-add load-gpu_cuda-tests
.PHONY: gpu-smoke-images

gpu-smoke-tests: gpu-smoke-images $(RUNTIME_BIN)
@$(call sudo,test/gpu:smoke_test,--runtime=runc -test.v $(ARGS))
@$(call install_runtime,$(RUNTIME),--nvproxy=true --nvproxy-docker=true)
@$(call sudo,test/gpu:smoke_test,--runtime=$(RUNTIME) -test.v $(ARGS))
@$(call sudo,test/gpu:smoke_test,--runtime=runc -test.v $(ARGS))
.PHONY: gpu-smoke-tests

cos-gpu-smoke-tests: gpu-smoke-images $(RUNTIME_BIN)
@$(call sudo,test/gpu:smoke_test,--runtime=runc -test.v --cos-gpu $(ARGS))
@$(call install_runtime,$(RUNTIME),--nvproxy=true)
@$(call sudo,test/gpu:smoke_test,--runtime=$(RUNTIME) -test.v --cos-gpu $(ARGS))
@$(call sudo,test/gpu:smoke_test,--runtime=runc -test.v --cos-gpu $(ARGS))
.PHONY: cos-gpu-smoke-tests

# Images needed for GPU tests.
Expand Down
2 changes: 1 addition & 1 deletion images/gpu/cuda-tests/cuda_malloc.cu
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ int main() {

std::cout << "Testing read/write syscalls on cudaMallocHost memory"
<< std::endl;
TestMallocHostReadWrite(device);
// TestMallocHostReadWrite(device);

std::cout << "Testing cudaMallocManaged(flags=cudaMemAttachGlobal)"
<< std::endl;
Expand Down
7 changes: 4 additions & 3 deletions pkg/test/dockerutil/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,13 @@ func (c *Container) Run(ctx context.Context, r RunOpts, args ...string) (string,

if err := c.Start(ctx); err != nil {
logs, _ := c.Logs(ctx)
return logs, err
return logs, fmt.Errorf("failed to start container: %w", err)
}

if err := c.Wait(ctx); err != nil {
info, ierr := c.client.ContainerInspect(ctx, c.id)
logs, _ := c.Logs(ctx)
return logs, err
return logs, fmt.Errorf("failed to wait for container: %w info: %+v info_err: %v", err, info.ContainerJSONBase.State, ierr)
}

return c.Logs(ctx)
Expand Down Expand Up @@ -288,7 +289,7 @@ func (c *Container) create(ctx context.Context, profileImage string, conf *conta
}
cont, err := c.client.ContainerCreate(ctx, conf, hostconf, nil, nil, c.Name)
if err != nil {
return err
return fmt.Errorf("ContainerCreate failed: %v warnings: %v", err, cont.Warnings)
}
c.id = cont.ID
return nil
Expand Down
Loading