BPF optimizer: Refactor removal operations across optimizers. #9860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl595505097
branch
from
b61b371
to
9afef9c
Compare
This introduces a `codeRemoval` type which acts as a tracker for removal of instructions during execution of an optimizer. This simplifies optimizers that use it, notably to avoid having to do backwards iterations in all of them. No heap allocations are performed unless code is actually removed, and only one allocation is performed when code is to be removed. PiperOrigin-RevId: 595575409
copybara-service
bot
force-pushed
the
test/cl595505097
branch
from
9afef9c
to
2097354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BPF optimizer: Refactor removal operations across optimizers.
This introduces a
codeRemovaltype which acts as a tracker for removal ofinstructions during execution of an optimizer.
This simplifies optimizers that use it, notably to avoid having to do
backwards iterations in all of them.
No heap allocations are performed unless code is actually removed, and only
one allocation is performed when code is to be removed.