Repatriate polynomial dialect #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_695820053
branch
5 times, most recently
from
8a5c996 to
421d82d
Compare
Due to some governance discussions in upstream MLIR [1], we decided it would be appropriate to move the polynomial dialect back into the HEIR tree. We also have some plans to make minor changes to the types, for instance changing the coefficient type to AnyType and removing the coefficient modulus to support things like RNS+modarith coefficient rings, and we felt it would be simpler to just make these changes in tree rather than burden the MLIR community and core maintainers with them. Cf. #1085 [1]: https://discourse.llvm.org/t/rfc-mlir-project-charter-and-restructuring/82896 PiperOrigin-RevId: 696112603
copybara-service
bot
force-pushed
the
test_695820053
branch
from
421d82d to
5dac435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repatriate polynomial dialect
Due to some governance discussions in upstream MLIR 1, we decided it would be appropriate to move the polynomial dialect back into the HEIR tree. We also have some plans to make minor changes to the types, for instance changing the coefficient type to AnyType and removing the coefficient modulus to support things like RNS+modarith coefficient rings, and we felt it would be simpler to just make these changes in tree rather than burden the MLIR community and core maintainers with them. Cf. #1085